Serialize error object with message in ExtraErrorData integration (getsentry#1958)

wong2 · HazAT · commit 7bbd283a7868 · 2019-03-26T12:56:59.000+01:00
diff --git a/packages/integrations/src/extraerrordata.ts b/packages/integrations/src/extraerrordata.ts
@@ -85,7 +85,7 @@ export class ExtraErrorData implements Integration {
         for (const key of errorKeys) {
           let value = error[key];
           if (isError(value)) {
-            value = (value as Error).name || (value as Error).constructor.name;
+            value = (value as Error).toString();
           }
           // tslint:disable:no-unsafe-any
           extraErrorInfo[key] = value;
diff --git a/packages/integrations/test/extraerrordata.test.ts b/packages/integrations/test/extraerrordata.test.ts
@@ -37,7 +37,7 @@ describe('ExtraErrorData()', () => {
 
     expect(enhancedEvent.extra).toEqual({
       TypeError: {
-        cause: 'SyntaxError',
+        cause: 'SyntaxError: bar',
       },
     });
   });

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ export class ExtraErrorData implements Integration {`
`85`	`85`	`for (const key of errorKeys) {`
`86`	`86`	`let value = error[key];`
`87`	`87`	`if (isError(value)) {`
`88`		`- value = (value as Error).name \|\| (value as Error).constructor.name;`
	`88`	`+ value = (value as Error).toString();`
`89`	`89`	`}`
`90`	`90`	`// tslint:disable:no-unsafe-any`
`91`	`91`	`extraErrorInfo[key] = value;`