ref: Add missing test for local Windows Tracekit scheme

kamilogorek · kamilogorek · commit 848c2a53afef · 2019-08-05T12:24:26.000+02:00
diff --git a/packages/browser/src/tracekit.ts b/packages/browser/src/tracekit.ts
@@ -477,7 +477,7 @@ TraceKit._computeStackTrace = (function _computeStackTraceWrapper() {
     }
 
     // Chromium based browsers: Chrome, Brave, new Opera, new Edge
-    var chrome = /^\s*at (?:(.*?) ?\()?((?:file|https?|blob|chrome-extension|native|eval|webpack|<anonymous>|[a-z]:|[-a-z]+(?=:)|\/).*?)(?::(\d+))?(?::(\d+))?\)?\s*$/i,
+    var chrome = /^\s*at (?:(.*?) ?\()?((?:file|https?|blob|chrome-extension|native|eval|webpack|<anonymous>|[-a-z]+:|\/).*?)(?::(\d+))?(?::(\d+))?\)?\s*$/i,
       // gecko regex: `(?:bundle|\d+\.js)`: `bundle` is for react native, `\d+\.js` also but specifically for ram bundles because it
       // generates filenames without a prefix like `file://` the filenames in the stacktrace are just 42.js
       // We need this specific case for now because we want no other regex to match.
diff --git a/packages/browser/test/unit/tracekit/custom.test.ts b/packages/browser/test/unit/tracekit/custom.test.ts
@@ -3,6 +3,28 @@ import { expect } from 'chai';
 import { _computeStackTrace } from '../../../src/tracekit';
 
 describe('Tracekit - Custom Tests', () => {
+  it('should parse errors with custom schemes', () => {
+    const CHROMIUM_EMBEDDED_FRAMEWORK_CUSTOM_SCHEME = {
+      message: 'message string',
+      name: 'Error',
+      stack: `Error: message string
+            at examplescheme://examplehost/cd351f7250857e22ceaa.worker.js:70179:15`,
+    };
+
+    const stacktrace = _computeStackTrace(CHROMIUM_EMBEDDED_FRAMEWORK_CUSTOM_SCHEME);
+
+    expect(stacktrace.stack).deep.equal([
+      {
+        args: [],
+        column: 15,
+        context: null,
+        func: '?',
+        line: 70179,
+        url: 'examplescheme://examplehost/cd351f7250857e22ceaa.worker.js',
+      },
+    ]);
+  });
+
   describe('should parse exceptions with native code frames', () => {
     it('in Chrome 73', () => {
       const CHROME73_NATIVE_CODE_EXCEPTION = {
@@ -238,4 +260,28 @@ describe('Tracekit - Custom Tests', () => {
       ]);
     });
   });
+
+  describe('should parse exceptions called within an iframe', () => {
+    it('in Electron Renderer', () => {
+      const CHROME_ELECTRON_RENDERER = {
+        message: "Cannot read property 'error' of undefined",
+        name: 'TypeError',
+        stack: `TypeError: Cannot read property 'error' of undefined
+            at TESTTESTTEST.someMethod (C:\\Users\\user\\path\\to\\file.js:295:108)`,
+      };
+
+      const stacktrace = _computeStackTrace(CHROME_ELECTRON_RENDERER);
+
+      expect(stacktrace.stack).deep.equal([
+        {
+          args: [],
+          column: 108,
+          context: null,
+          func: 'TESTTESTTEST.someMethod',
+          line: 295,
+          url: 'C:\\Users\\user\\path\\to\\file.js',
+        },
+      ]);
+    });
+  });
 });
diff --git a/packages/browser/test/unit/tracekit/original.test.ts b/packages/browser/test/unit/tracekit/original.test.ts
@@ -38,7 +38,6 @@ import {
   SAFARI_7,
   SAFARI_8,
   SAFARI_8_EVAL,
-  CHROMIUM_EMBEDDED_FRAMEWORK_CUSTOM_SCHEME
 } from './originalfixtures';
 
 describe('Tracekit - Original Tests', () => {
@@ -1245,18 +1244,4 @@ describe('Tracekit - Original Tests', () => {
       context: null,
     });
   });
-
-  it('should parse Chromium Embedded Framework errors with custom schemes', () => {
-    const stackFrames = _computeStackTrace(CHROMIUM_EMBEDDED_FRAMEWORK_CUSTOM_SCHEME);
-    expect(stackFrames).to.be.ok;
-    expect(stackFrames.stack.length).to.equal(1);
-    expect(stackFrames.stack[0]).to.deep.equal({
-      url: 'examplescheme://examplehost/cd351f7250857e22ceaa.worker.js',
-      func: '?',
-      args: [],
-      line: 70179,
-      column: 15,
-      context: null,
-    });
-  })
 });
diff --git a/packages/browser/test/unit/tracekit/originalfixtures.ts b/packages/browser/test/unit/tracekit/originalfixtures.ts
@@ -482,11 +482,3 @@ export const ANDROID_REACT_NATIVE_PROD = {
     'value@index.android.bundle:29:927\n' +
     '[native code]',
 };
-
-export const CHROMIUM_EMBEDDED_FRAMEWORK_CUSTOM_SCHEME = {
-  message: 'message string',
-  name: 'Error',
-  stack:
-    'Error: message string\n' +
-    '    at examplescheme://examplehost/cd351f7250857e22ceaa.worker.js:70179:15'
-};

Original file line number	Diff line number	Diff line change
`@@ -477,7 +477,7 @@ TraceKit._computeStackTrace = (function _computeStackTraceWrapper() {`
`477`	`477`	`}`
`478`	`478`
`479`	`479`	`// Chromium based browsers: Chrome, Brave, new Opera, new Edge`
`480`		`- var chrome = /^\sat (?:(.?) ?\()?((?:file\|https?\|blob\|chrome-extension\|native\|eval\|webpack\|<anonymous>\|[a-z]:\|[-a-z]+(?=:)\|\/).?)(?::(\d+))?(?::(\d+))?\)?\s$/i,`
	`480`	`+ var chrome = /^\sat (?:(.?) ?\()?((?:file\|https?\|blob\|chrome-extension\|native\|eval\|webpack\|<anonymous>\|[-a-z]+:\|\/).?)(?::(\d+))?(?::(\d+))?\)?\s$/i,`
`481`	`481`	// gecko regex: `(?:bundle\|\d+\.js)`: `bundle` is for react native, `\d+\.js` also but specifically for ram bundles because it
`482`	`482`	// generates filenames without a prefix like `file://` the filenames in the stacktrace are just 42.js
`483`	`483`	`// We need this specific case for now because we want no other regex to match.`