style(lint): Introduce no-console rule to some pkg (getsentry#2112)

BYK · web-flow · commit 9af64770bdd4 · 2019-06-07T19:00:23.000+03:00
Adds [no-console](https://palantir.github.io/tslint/rules/no-console/) TSLint rule to integrations and browser repos and fixes these warnings.
diff --git a/packages/browser/tslint.json b/packages/browser/tslint.json
@@ -1,3 +1,6 @@
 {
-  "extends": "@sentry/typescript/tslint"
+  "extends": "@sentry/typescript/tslint",
+  "rules": {
+    "no-console": true
+  }
 }
diff --git a/packages/integrations/src/angular.ts b/packages/integrations/src/angular.ts
@@ -1,5 +1,5 @@
 import { Event, EventProcessor, Hub, Integration } from '@sentry/types';
-import { getGlobalObject } from '@sentry/utils';
+import { getGlobalObject, logger } from '@sentry/utils';
 
 // See https://github.com/angular/angular.js/blob/v1.4.7/src/minErr.js
 const angularPattern = /^\[((?:[$a-zA-Z0-9]+:)?(?:[$a-zA-Z0-9]+))\] (.*?)\n?(\S+)$/;
@@ -48,7 +48,7 @@ export class Angular implements Integration {
    */
   public setupOnce(_: (callback: EventProcessor) => void, getCurrentHub: () => Hub): void {
     if (!this._angular) {
-      console.error('AngularIntegration is missing an Angular instance');
+      logger.error('AngularIntegration is missing an Angular instance');
       return;
     }
 
diff --git a/packages/integrations/src/ember.ts b/packages/integrations/src/ember.ts
@@ -1,5 +1,5 @@
 import { EventProcessor, Hub, Integration } from '@sentry/types';
-import { getGlobalObject } from '@sentry/utils';
+import { getGlobalObject, logger } from '@sentry/utils';
 
 /** JSDoc */
 export class Ember implements Integration {
@@ -32,7 +32,7 @@ export class Ember implements Integration {
     // tslint:disable:no-unsafe-any
 
     if (!this._Ember) {
-      console.error('EmberIntegration is missing an Ember instance');
+      logger.error('EmberIntegration is missing an Ember instance');
       return;
     }
 
diff --git a/packages/integrations/src/extraerrordata.ts b/packages/integrations/src/extraerrordata.ts
@@ -1,5 +1,5 @@
 import { Event, EventHint, EventProcessor, ExtendedError, Hub, Integration } from '@sentry/types';
-import { isError, isPlainObject, normalize } from '@sentry/utils';
+import { isError, isPlainObject, logger, normalize } from '@sentry/utils';
 
 /** JSDoc */
 interface ExtraErrorDataOptions {
@@ -94,7 +94,7 @@ export class ExtraErrorData implements Integration {
         };
       }
     } catch (oO) {
-      console.error('Unable to extract extra data from the Error object:', oO);
+      logger.error('Unable to extract extra data from the Error object:', oO);
     }
 
     return result;
diff --git a/packages/integrations/src/tracing.ts b/packages/integrations/src/tracing.ts
@@ -1,5 +1,5 @@
 import { EventProcessor, Hub, Integration } from '@sentry/types';
-import { consoleSandbox, fill, getGlobalObject, isMatchingPattern, supportsNativeFetch } from '@sentry/utils';
+import { fill, getGlobalObject, isMatchingPattern, logger, supportsNativeFetch } from '@sentry/utils';
 
 /** JSDoc */
 interface TracingOptions {
@@ -37,16 +37,12 @@ export class Tracing implements Integration {
    */
   public constructor(private readonly _options: TracingOptions = {}) {
     if (!Array.isArray(_options.tracingOrigins) || _options.tracingOrigins.length === 0) {
-      consoleSandbox(() => {
-        const defaultTracingOrigins = ['localhost', /^\//];
-        // @ts-ignore
-        console.warn(
-          'Sentry: You need to define `tracingOrigins` in the options. Set an array of urls or patterns to trace.',
-        );
-        // @ts-ignore
-        console.warn(`Sentry: We added a reasonable default for you: ${defaultTracingOrigins}`);
-        _options.tracingOrigins = defaultTracingOrigins;
-      });
+      const defaultTracingOrigins = ['localhost', /^\//];
+      logger.warn(
+        'Sentry: You need to define `tracingOrigins` in the options. Set an array of urls or patterns to trace.',
+      );
+      logger.warn(`Sentry: We added a reasonable default for you: ${defaultTracingOrigins}`);
+      _options.tracingOrigins = defaultTracingOrigins;
     }
   }
 
diff --git a/packages/integrations/src/vue.ts b/packages/integrations/src/vue.ts
@@ -1,5 +1,5 @@
 import { EventProcessor, Hub, Integration } from '@sentry/types';
-import { getGlobalObject, isPlainObject } from '@sentry/utils';
+import { getGlobalObject, isPlainObject, logger } from '@sentry/utils';
 
 /** JSDoc */
 interface Metadata {
@@ -65,7 +65,7 @@ export class Vue implements Integration {
     // tslint:disable:no-unsafe-any
 
     if (!this._Vue || !this._Vue.config) {
-      console.error('VueIntegration is missing a Vue instance');
+      logger.error('VueIntegration is missing a Vue instance');
       return;
     }
 
diff --git a/packages/integrations/tslint.json b/packages/integrations/tslint.json
@@ -1,3 +1,6 @@
 {
-  "extends": "@sentry/typescript/tslint"
+  "extends": "@sentry/typescript/tslint",
+  "rules": {
+    "no-console": true
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,6 @@`
`1`	`1`	`{`
`2`		`- "extends": "@sentry/typescript/tslint"`
	`2`	`+ "extends": "@sentry/typescript/tslint",`
	`3`	`+ "rules": {`
	`4`	`+ "no-console": true`
	`5`	`+ }`
`3`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`import { Event, EventHint, EventProcessor, ExtendedError, Hub, Integration } from '@sentry/types';`
`2`		`-import { isError, isPlainObject, normalize } from '@sentry/utils';`
	`2`	`+import { isError, isPlainObject, logger, normalize } from '@sentry/utils';`
`3`	`3`
`4`	`4`	`/** JSDoc */`
`5`	`5`	`interface ExtraErrorDataOptions {`
`@@ -94,7 +94,7 @@ export class ExtraErrorData implements Integration {`
`94`	`94`	`};`
`95`	`95`	`}`
`96`	`96`	`} catch (oO) {`
`97`		`- console.error('Unable to extract extra data from the Error object:', oO);`
	`97`	`+ logger.error('Unable to extract extra data from the Error object:', oO);`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`return result;`