fix: Always trigger default browser onerror handler (getsentry#2348)

kamilogorek · web-flow · commit c565329fac48 · 2019-12-06T15:32:23.000+01:00
diff --git a/packages/browser/src/integrations/globalhandlers.ts b/packages/browser/src/integrations/globalhandlers.ts
@@ -92,7 +92,7 @@ export class GlobalHandlers implements Integration {
         if (self._oldOnErrorHandler) {
           return self._oldOnErrorHandler.apply(this, arguments);
         }
-        return true;
+        return false;
       }
 
       const client = currentHub.getClient();
@@ -121,7 +121,7 @@ export class GlobalHandlers implements Integration {
         return self._oldOnErrorHandler.apply(this, arguments);
       }
 
-      return true;
+      return false;
     };
 
     this._onErrorHandlerInstalled = true;

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ export class GlobalHandlers implements Integration {`
`92`	`92`	`if (self._oldOnErrorHandler) {`
`93`	`93`	`return self._oldOnErrorHandler.apply(this, arguments);`
`94`	`94`	`}`
`95`		`- return true;`
	`95`	`+ return false;`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`const client = currentHub.getClient();`
`@@ -121,7 +121,7 @@ export class GlobalHandlers implements Integration {`
`121`	`121`	`return self._oldOnErrorHandler.apply(this, arguments);`
`122`	`122`	`}`
`123`	`123`
`124`		`- return true;`
	`124`	`+ return false;`
`125`	`125`	`};`
`126`	`126`
`127`	`127`	`this._onErrorHandlerInstalled = true;`