Update tracing.ts and hub interface

kamilogorek · kamilogorek · commit dd7bb41cd042 · 2019-11-01T11:25:42.000+01:00
diff --git a/packages/integrations/src/tracing.ts b/packages/integrations/src/tracing.ts
@@ -74,9 +74,12 @@ export class Tracing implements Integration {
    * @param transaction Optional transaction
    */
   public static startTrace(hub: Hub, transaction?: string): void {
+    const span = hub.startSpan({
+      transaction,
+    });
+
     hub.configureScope(scope => {
-      // scope.startSpan();
-      scope.setTransaction(transaction);
+      scope.setSpan(span);
     });
   }
 
diff --git a/packages/types/src/hub.ts b/packages/types/src/hub.ts
@@ -4,6 +4,7 @@ import { Event, EventHint } from './event';
 import { Integration, IntegrationClass } from './integration';
 import { Scope } from './scope';
 import { Severity } from './severity';
+import { Span, SpanDetails } from './span';
 import { User } from './user';
 
 /**
@@ -170,4 +171,10 @@ export interface Hub {
 
   /** Returns all trace headers that are currently on the top scope. */
   traceHeaders(): { [key: string]: string };
+
+  /** JSDoc */
+  startSpan(spanDetails?: SpanDetails): Span;
+
+  /** JSDoc */
+  finishSpan(span: Span): string | undefined;
 }
