ref: Mark failed transactions

kamilogorek · kamilogorek · commit e58a8de9aba6 · 2019-11-01T11:28:28.000+01:00
diff --git a/packages/node/src/handlers.ts b/packages/node/src/handlers.ts
@@ -37,10 +37,14 @@ export function tracingHandler(): (
     hub.configureScope(scope => {
       scope.setSpan(transaction);
     });
-    res
-      .once('response', () => transaction.setSuccess())
-      .once('error', () => transaction.setFailure())
-      .once('finish', () => transaction.finish());
+    res.once('finish', () => {
+      if (res.statusCode >= 500) {
+        transaction.setFailure();
+      } else {
+        transaction.setSuccess();
+      }
+      transaction.finish();
+    });
     next();
   };
 }
diff --git a/packages/node/src/integrations/http.ts b/packages/node/src/integrations/http.ts
@@ -92,6 +92,7 @@ function createHandlerWrapper(
           if (breadcrumbsEnabled) {
             addRequestBreadcrumb('response', requestUrl, this, res);
           }
+          // TODO: Mark >= 500 as failed as well?
           if (tracingEnabled) {
             span.setSuccess();
             span.finish();

Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,7 @@ function createHandlerWrapper(`
`92`	`92`	`if (breadcrumbsEnabled) {`
`93`	`93`	`addRequestBreadcrumb('response', requestUrl, this, res);`
`94`	`94`	`}`
	`95`	`+ // TODO: Mark >= 500 as failed as well?`
`95`	`96`	`if (tracingEnabled) {`
`96`	`97`	`span.setSuccess();`
`97`	`98`	`span.finish();`