Better tests :)

kamilogorek · kamilogorek · commit e5fb0e2b485f · 2020-06-10T15:32:06.000+02:00
diff --git a/packages/hub/test/hub.test.ts b/packages/hub/test/hub.test.ts
@@ -6,10 +6,17 @@ const clientFn: any = jest.fn();
 
 describe('Hub', () => {
   afterEach(() => {
-    jest.resetAllMocks();
+    jest.restoreAllMocks();
     jest.useRealTimers();
   });
 
+  test('call bindClient with provided client when constructing new instance', () => {
+    const testClient: any = { setupIntegrations: jest.fn() };
+    const spy = jest.spyOn(Hub.prototype, 'bindClient');
+    new Hub(testClient);
+    expect(spy).toHaveBeenCalledWith(testClient);
+  });
+
   test('push process into stack', () => {
     const hub = new Hub();
     expect(hub.getStack()).toHaveLength(1);
@@ -52,30 +59,33 @@ describe('Hub', () => {
     });
 
     describe('bindClient', () => {
-      test('simple', () => {
+      test('should override curent client', () => {
+        const testClient: any = { setupIntegrations: jest.fn() };
+        const nextClient: any = { setupIntegrations: jest.fn() };
+        const hub = new Hub(testClient);
+        hub.bindClient(nextClient);
+        expect(hub.getStack()).toHaveLength(1);
+        expect(hub.getStack()[0].client).toBe(nextClient);
+      });
+
+      test('should bind client to the top-most layer', () => {
         const testClient: any = { bla: 'a' };
+        const nextClient: any = { foo: 'bar' };
         const hub = new Hub(testClient);
-        const ndClient: any = { foo: 'bar' };
         hub.pushScope();
-        hub.bindClient(ndClient);
+        hub.bindClient(nextClient);
         expect(hub.getStack()).toHaveLength(2);
         expect(hub.getStack()[0].client).toBe(testClient);
-        expect(hub.getStack()[1].client).toBe(ndClient);
-      });
-      test('call setupIntegrations', () => {
-        const setupIntegrations = jest.fn();
-        const testClient: any = { setupIntegrations };
-        const hub = new Hub(testClient);
-        hub.bindClient(testClient);
-        expect(setupIntegrations).toHaveBeenCalled();
+        expect(hub.getStack()[1].client).toBe(nextClient);
       });
 
-      test('call setupIntegrations from constructor', () => {
-        const setupIntegrations = jest.fn();
-        const testClient: any = { setupIntegrations };
+      test('should call setupIntegration method of passed client', () => {
+        const testClient: any = { setupIntegrations: jest.fn() };
+        const nextClient: any = { setupIntegrations: jest.fn() };
         const hub = new Hub(testClient);
-        expect(setupIntegrations).toHaveBeenCalled();
-        expect(hub).toBeTruthy();
+        hub.bindClient(nextClient);
+        expect(testClient.setupIntegrations).toHaveBeenCalled();
+        expect(nextClient.setupIntegrations).toHaveBeenCalled();
       });
     });
 
