feat: Extract prototyped data in extractUserData (getsentry#2247)

jbloxham · kamilogorek · commit ea27f8e4627c · 2019-09-25T12:36:02.000+02:00
diff --git a/packages/node/src/handlers.ts b/packages/node/src/handlers.ts
@@ -143,7 +143,7 @@ function extractUserData(req: { [key: string]: any }, keys: boolean | string[]):
   const attributes = Array.isArray(keys) ? keys : DEFAULT_USER_KEYS;
 
   attributes.forEach(key => {
-    if ({}.hasOwnProperty.call(req.user, key)) {
+    if (key in req.user) {
       user[key] = (req.user as { [key: string]: string })[key];
     }
   });

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ function extractUserData(req: { [key: string]: any }, keys: boolean \| string[]):`
`143`	`143`	`const attributes = Array.isArray(keys) ? keys : DEFAULT_USER_KEYS;`
`144`	`144`
`145`	`145`	`attributes.forEach(key => {`
`146`		`- if ({}.hasOwnProperty.call(req.user, key)) {`
	`146`	`+ if (key in req.user) {`
`147`	`147`	`user[key] = (req.user as { [key: string]: string })[key];`
`148`	`148`	`}`
`149`	`149`	`});`