fix: sent_at for envelope headers (getsentry#2597)

HazAT · Sija · AbhiPrasad · web-flow · commit edbc2df1ba18 · 2020-05-18T15:43:09.000+02:00
* fix: sent_at for envelope headers

* chore: Changelog

* Update CHANGELOG.md

Co-authored-by: Sijawusz Pur Rahnama &lt;sija@sija.pl&gt;

* Update packages/core/src/request.ts

Co-authored-by: Abhijeet Prasad &lt;AbhiPrasad@users.noreply.github.com&gt;

Co-authored-by: Sijawusz Pur Rahnama &lt;sija@sija.pl&gt;
Co-authored-by: Abhijeet Prasad &lt;AbhiPrasad@users.noreply.github.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
 - [apm] fix: Use proper type name for op #2584
+- [core] fix: sent_at for envelope headers to use same clock #2597
 - [apm] fix: Improve bundle size by moving span status to @sentry/apm #2589
 
 ## 5.16.0
diff --git a/packages/core/src/request.ts b/packages/core/src/request.ts
@@ -1,5 +1,6 @@
 import { getCurrentHub } from '@sentry/hub';
 import { Event } from '@sentry/types';
+import { timestampWithMs } from '@sentry/utils';
 
 import { API } from './api';
 
@@ -34,7 +35,9 @@ export function eventToSentryRequest(event: Event, api: API): SentryRequest {
   if (useEnvelope) {
     const envelopeHeaders = JSON.stringify({
       event_id: event.event_id,
-      sent_at: new Date().toISOString(),
+      // We need to add * 1000 since we divide it by 1000 by default but JS works with ms precision
+      // The reason we use timestampWithMs here is that all clocks across the SDK use the same clock
+      sent_at: new Date(timestampWithMs() * 1000).toISOString(),
     });
     const itemHeaders = JSON.stringify({
       type: event.type,
