fix: Fix typo in header name (getsentry#657)

untitaker · web-flow · commit 301141d87dfa · 2020-03-25T13:39:26.000+01:00
diff --git a/sentry_sdk/transport.py b/sentry_sdk/transport.py
@@ -147,7 +147,7 @@ def _update_rate_limits(self, response):
 
         # new sentries with more rate limit insights.  We honor this header
         # no matter of the status code to update our internal rate limits.
-        header = response.headers.get("x-sentry-rate-limit")
+        header = response.headers.get("x-sentry-rate-limits")
         if header:
             self._disabled_until.update(_parse_rate_limits(header))
 
diff --git a/tests/test_transport.py b/tests/test_transport.py
@@ -137,7 +137,7 @@ def test_data_category_limits(httpserver, capsys, caplog, response_code):
     httpserver.serve_content(
         "hm",
         response_code,
-        headers={"X-Sentry-Rate-Limit": "4711:transaction:organization"},
+        headers={"X-Sentry-Rate-Limits": "4711:transaction:organization"},
     )
 
     client.capture_event({"type": "transaction"})
@@ -168,7 +168,7 @@ def test_complex_limits_without_data_category(
         dict(dsn="http://foobar@{}/123".format(httpserver.url[len("http://") :]))
     )
     httpserver.serve_content(
-        "hm", response_code, headers={"X-Sentry-Rate-Limit": "4711::organization"},
+        "hm", response_code, headers={"X-Sentry-Rate-Limits": "4711::organization"},
     )
 
     client.capture_event({"type": "transaction"})

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ def test_data_category_limits(httpserver, capsys, caplog, response_code):`
`137`	`137`	`httpserver.serve_content(`
`138`	`138`	`"hm",`
`139`	`139`	`response_code,`
`140`		`- headers={"X-Sentry-Rate-Limit": "4711:transaction:organization"},`
	`140`	`+ headers={"X-Sentry-Rate-Limits": "4711:transaction:organization"},`
`141`	`141`	`)`
`142`	`142`
`143`	`143`	`client.capture_event({"type": "transaction"})`
`@@ -168,7 +168,7 @@ def test_complex_limits_without_data_category(`
`168`	`168`	`dict(dsn="http://foobar@{}/123".format(httpserver.url[len("http://") :]))`
`169`	`169`	`)`
`170`	`170`	`httpserver.serve_content(`
`171`		`- "hm", response_code, headers={"X-Sentry-Rate-Limit": "4711::organization"},`
	`171`	`+ "hm", response_code, headers={"X-Sentry-Rate-Limits": "4711::organization"},`
`172`	`172`	`)`
`173`	`173`
`174`	`174`	`client.capture_event({"type": "transaction"})`