fix: Do not unnecessarily ignore tornado.application logger (getsentry#554)

untitaker · web-flow · commit 3b00f57588c7 · 2019-11-17T16:55:44.000+01:00
diff --git a/sentry_sdk/integrations/tornado.py b/sentry_sdk/integrations/tornado.py
@@ -50,7 +50,6 @@ def setup_once():
                 "The tornado integration for Sentry requires Python 3.6+ or the aiocontextvars package"
             )
 
-        ignore_logger("tornado.application")
         ignore_logger("tornado.access")
 
         old_execute = RequestHandler._execute
diff --git a/tests/integrations/tornado/test_tornado.py b/tests/integrations/tornado/test_tornado.py
@@ -54,6 +54,7 @@ def test_basic(tornado_testcase, sentry_init, capture_events):
     event, = events
     exception, = event["exception"]["values"]
     assert exception["type"] == "ZeroDivisionError"
+    assert exception["mechanism"]["type"] == "tornado"
 
     request = event["request"]
     host = request["headers"]["Host"]

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,6 @@ def setup_once():`
`50`	`50`	`"The tornado integration for Sentry requires Python 3.6+ or the aiocontextvars package"`
`51`	`51`	`)`
`52`	`52`
`53`		`- ignore_logger("tornado.application")`
`54`	`53`	`ignore_logger("tornado.access")`
`55`	`54`
`56`	`55`	`old_execute = RequestHandler._execute`