feat: Test under Python 3.8 (getsentry#532)

untitaker · web-flow · commit 9dc161b92893 · 2019-10-17T00:09:02.000+02:00
* feat: Test under Python 3.8

* ref: Test more 3.8, remove 3.4 from test matrix for integrations

* ref: Update hypothesis

* ref: Fix resource warning

* fix: Make hypothesis optional

* ref: Bump werkzeug

* fix: Remove 3.8 tests for old aiohttp

* fix: sanic is broken on py3.8

* fix: Remove 3.8 tests for beam
diff --git a/.travis.yml b/.travis.yml
@@ -23,15 +23,21 @@ matrix:
   include:
     - python: "3.7"
       dist: xenial
+
+    - python: "3.8"
+      dist: xenial
+
     - name: Linting
       python: "3.6"
       install:
         - pip install tox
       script: tox -e linters
+
     - python: "3.6"
       name: Distribution packages
       install: false
       script: make travis-upload-dist
+
     - python: "3.6"
       name: Build documentation
       install: false
diff --git a/test-requirements.txt b/test-requirements.txt
@@ -1,8 +1,7 @@
-hypothesis==3.69.9
 pytest==3.7.3
 pytest-forked==1.1.0
 tox==3.7.0
-Werkzeug==0.15.3
+Werkzeug==0.15.5
 pytest-localserver==0.4.1
 pytest-cov==2.6.0
 gevent
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -166,11 +166,12 @@ def inner(event):
             # not dealing with the subprocess API right now
             file = tmpdir.join("event-{}".format(uuid.uuid4().hex))
             file.write(json.dumps(dict(event)))
-            output = json.loads(
-                subprocess.check_output(
-                    [SEMAPHORE, "process-event"], stdin=file.open()
-                ).decode("utf-8")
-            )
+            with file.open() as f:
+                output = json.loads(
+                    subprocess.check_output(
+                        [SEMAPHORE, "process-event"], stdin=f
+                    ).decode("utf-8")
+                )
             _no_errors_in_semaphore_response(output)
             output.pop("_meta", None)
             return output
diff --git a/tests/test_serializer.py b/tests/test_serializer.py
@@ -1,26 +1,32 @@
 from datetime import datetime
 
-from hypothesis import given, example
-import hypothesis.strategies as st
 
 import pytest
 
 from sentry_sdk.serializer import serialize
 
-
-@given(
-    dt=st.datetimes(min_value=datetime(2000, 1, 1, 0, 0, 0), timezones=st.just(None))
-)
-@example(dt=datetime(2001, 1, 1, 0, 0, 0, 999500))
-def test_datetime_precision(dt, semaphore_normalize):
-    event = serialize({"timestamp": dt})
-    normalized = semaphore_normalize(event)
-
-    if normalized is None:
-        pytest.skip("no semaphore available")
-
-    dt2 = datetime.utcfromtimestamp(normalized["timestamp"])
-
-    # Float glitches can happen, and more glitches can happen
-    # because we try to work around some float glitches in semaphore
-    assert (dt - dt2).total_seconds() < 1.0
+try:
+    from hypothesis import given, example
+    import hypothesis.strategies as st
+except ImportError:
+    pass
+else:
+
+    @given(
+        dt=st.datetimes(
+            min_value=datetime(2000, 1, 1, 0, 0, 0), timezones=st.just(None)
+        )
+    )
+    @example(dt=datetime(2001, 1, 1, 0, 0, 0, 999500))
+    def test_datetime_precision(dt, semaphore_normalize):
+        event = serialize({"timestamp": dt})
+        normalized = semaphore_normalize(event)
+
+        if normalized is None:
+            pytest.skip("no semaphore available")
+
+        dt2 = datetime.utcfromtimestamp(normalized["timestamp"])
+
+        # Float glitches can happen, and more glitches can happen
+        # because we try to work around some float glitches in semaphore
+        assert (dt - dt2).total_seconds() < 1.0
diff --git a/tests/utils/test_general.py b/tests/utils/test_general.py
@@ -4,8 +4,6 @@
 
 import pytest
 
-from hypothesis import given
-import hypothesis.strategies as st
 
 from sentry_sdk.utils import (
     BadDsn,
@@ -18,14 +16,20 @@
 )
 from sentry_sdk._compat import text_type
 
-any_string = st.one_of(st.binary(), st.text())
 
+try:
+    from hypothesis import given
+    import hypothesis.strategies as st
+except ImportError:
+    pass
+else:
+    any_string = st.one_of(st.binary(), st.text())
 
-@given(x=any_string)
-def test_safe_repr_never_broken_for_strings(x):
-    r = safe_repr(x)
-    assert isinstance(r, text_type)
-    assert u"broken repr" not in r
+    @given(x=any_string)
+    def test_safe_repr_never_broken_for_strings(x):
+        r = safe_repr(x)
+        assert isinstance(r, text_type)
+        assert u"broken repr" not in r
 
 
 def test_safe_repr_regressions():
diff --git a/tox.ini b/tox.ini
@@ -6,54 +6,55 @@
 [tox]
 envlist =
     # === Core ===
-    py{2.7,3.4,3.5,3.6,3.7}
+    py{2.7,3.4,3.5,3.6,3.7,3.8}
     pypy
 
 
     # === Integrations ===
     # Formatting: 1 blank line between different integrations.
 
-    py3.7-django-{2.2,dev}
+    py{3.7,3.8}-django-{2.2,dev}
     {py3.5,py3.6,py3.7}-django-{2.0,2.1}
     {pypy,py2.7,py3.5}-django-1.11
-    {pypy,py2.7,py3.4,py3.5}-django-{1.8,1.9,1.10}
-    {pypy,py2.7,py3.4}-django-1.7
+    {pypy,py2.7,py3.5}-django-{1.8,1.9,1.10}
+    {pypy,py2.7}-django-1.7
     {pypy,py2.7}-django-1.6
 
-    {pypy,py2.7,py3.5,py3.6,py3.7}-flask-{1.1,1.0,0.11,0.12,dev}
+    {pypy,py2.7,py3.5,py3.6,py3.7,py3.8}-flask-{1.1,1.0,0.11,0.12,dev}
 
-    {pypy,py2.7,py3.5,py3.6,py3.7}-bottle-0.12
+    {pypy,py2.7,py3.5,py3.6,py3.7,py3.8}-bottle-0.12
 
     {pypy,py2.7,py3.5,py3.6,py3.7}-falcon-1.4
-    {pypy,py2.7,py3.5,py3.6,py3.7}-falcon-2.0
+    {pypy,py2.7,py3.5,py3.6,py3.7,py3.8}-falcon-2.0
 
     {py3.5,py3.6,py3.7}-sanic-{0.8,18}
 
-    {pypy,py2.7,py3.5,py3.6,py3.7}-celery-{4.1,4.2,4.3}
+    {pypy,py2.7,py3.5,py3.6,py3.7,py3.8}-celery-{4.1,4.2,4.3}
     {pypy,py2.7}-celery-3
 
     py2.7-beam-{12,13}
-    py3.7-beam-{12,13, master}
+    py3.7-beam-{12,13,master}
 
     # The aws_lambda tests deploy to the real AWS and have their own matrix of Python versions.
     py3.7-aws_lambda
 
-    {pypy,py2.7,py3.5,py3.6,py3.7}-pyramid-{1.3,1.4,1.5,1.6,1.7,1.8,1.9,1.10}
+    {pypy,py2.7,py3.5,py3.6,py3.7,py3.8}-pyramid-{1.3,1.4,1.5,1.6,1.7,1.8,1.9,1.10}
 
     {pypy,py2.7,py3.5,py3.6}-rq-{0.6,0.7,0.8,0.9,0.10,0.11}
-    {pypy,py2.7,py3.5,py3.6,py3.7}-rq-{0.12,0.13,1.0,1.1}
+    {pypy,py2.7,py3.5,py3.6,py3.7,py3.8}-rq-{0.12,0.13,1.0,1.1}
 
-    py3.7-aiohttp-{3.5,3.6}
+    py3.7-aiohttp-3.5
+    py{3.7,3.8}-aiohttp-3.6
 
-    {py3.7}-tornado-{5,6}
+    {py3.7,py3.8}-tornado-{5,6}
 
-    {py2.7,py3.7}-requests
+    {py2.7,py3.8}-requests
 
-    {py2.7,py3.7}-redis
+    {py2.7,py3.7,py3.8}-redis
 
-    py3.7-asgi
+    py{3.7,3.8}-asgi
 
-    {py2.7,py3.7}-sqlalchemy-{1.2,1.3}
+    {py2.7,py3.7,py3.8}-sqlalchemy-{1.2,1.3}
 
 [testenv]
 deps =
@@ -157,6 +158,8 @@ deps =
     linters: mypy>=0.730
     linters: flake8-bugbear>=19.8.0
 
+    py3.8: hypothesis
+
 setenv =
     PYTHONDONTWRITEBYTECODE=1
     TESTPATH=tests
@@ -196,6 +199,7 @@ basepython =
     py3.5: python3.5
     py3.6: python3.6
     py3.7: python3.7
+    py3.8: python3.8
     linters: python3
     pypy: pypy
 
