fix: Record UTC timestamps for transactions (getsentry#547)

untitaker · web-flow · commit d64e7502634d · 2019-11-06T20:15:42.000+01:00
* fix: Record UTC timestamps for transactions

* fix: Do not upload coverage to zeus if no api token is available

* noop for bot

* syntax?
diff --git a/.travis.yml b/.travis.yml
@@ -62,7 +62,7 @@ script:
   - coverage combine .coverage*
   - coverage xml -i
   - codecov --file coverage.xml
-  - zeus upload -t "application/x-cobertura+xml" coverage.xml
+  - '[[ -z "$ZEUS_API_TOKEN" ]] || zeus upload -t "application/x-cobertura+xml" coverage.xml'
 
 notifications:
   webhooks:
diff --git a/sentry_sdk/tracing.py b/sentry_sdk/tracing.py
@@ -133,7 +133,7 @@ def __init__(
         self.hub = hub
         self._tags = {}  # type: Dict[str, str]
         self._data = {}  # type: Dict[str, Any]
-        self.start_timestamp = datetime.now()
+        self.start_timestamp = datetime.utcnow()
 
         #: End timestamp of span
         self.timestamp = None  # type: Optional[datetime]
@@ -279,7 +279,7 @@ def finish(self, hub=None):
             # This transaction is already finished, so we should not flush it again.
             return None
 
-        self.timestamp = datetime.now()
+        self.timestamp = datetime.utcnow()
 
         _maybe_create_breadcrumbs_from_span(hub, self)
 
diff --git a/tests/test_transport.py b/tests/test_transport.py
@@ -44,7 +44,7 @@ def test_transport_works(
     Hub.current.bind_client(client)
     request.addfinalizer(lambda: Hub.current.bind_client(None))
 
-    add_breadcrumb(level="info", message="i like bread", timestamp=datetime.now())
+    add_breadcrumb(level="info", message="i like bread", timestamp=datetime.utcnow())
     capture_message("löl")
 
     getattr(client, client_flush_method)()
