Merge pull request #1480 from Bene-Graham/fix-bug-1027

alubbe · web-flow · commit ab776ef63d6e · 2020-10-01T19:08:03.000+02:00
Fixed undefined ref error when setting a data validation that is a range of cells at the worksheet level
diff --git a/lib/xlsx/xform/sheet/data-validations-xform.js b/lib/xlsx/xform/sheet/data-validations-xform.js
@@ -51,7 +51,14 @@ function optimiseDataValidations(model) {
   return dvList
     .map(dv => {
       if (!dv.marked) {
-        const addr = colCache.decodeAddress(dv.address);
+        const addr = colCache.decodeEx(dv.address);
+        if (addr.dimensions) {
+          dvMap[addr.dimensions].marked = true;
+          return {
+            ...dv.dataValidation,
+            sqref: dv.address,
+          };
+        }
 
         // iterate downwards - finding matching cells
         let height = 1;
diff --git a/spec/integration/issues/issue-1027-sheet-defined-data-validate.spec.js b/spec/integration/issues/issue-1027-sheet-defined-data-validate.spec.js
@@ -0,0 +1,23 @@
+const ExcelJS = verquire('exceljs');
+
+const TEST_XLSX_FILE_NAME = './spec/out/wb.test.xlsx';
+
+describe('github issues', () => {
+  it('issue 1027 - Broken due to Cannot set property \'marked\' of undefined error', () => {
+    const wb = new ExcelJS.Workbook();
+    const ws = wb.addWorksheet('Sheet1');
+
+    const range = 'A2:A1048576';
+
+    ws.dataValidations.model[range] = {
+      allowBlank: true,
+      error: 'Please use the drop down to select a valid value',
+      errorTitle: 'Invalid Selection',
+      formulae: ['"Apples,Bananas,Oranges"'],
+      showErrorMessage: true,
+      type: 'list',
+    };
+
+    return wb.xlsx.writeFile(TEST_XLSX_FILE_NAME);
+  });
+});
