-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[BUG] addRows
is not defined when using Streaming I/O.
#1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@shusson You can try the following code, I will create a pull request as soon as possible, Of course, we are also very happy to accept your contribution 😄. (async () => {
var options = {
filename: './ownerTest/demoTest/read/issue_1277.xlsx',
useStyles: true,
useSharedStrings: true
}
var wb = new Excel.stream.xlsx.WorkbookWriter(options);
var ws = wb.addWorksheet('bort');
var rows = [
[5,'Bob',new Date()],
[6,'Bo2b',new Date()]
];
rows.forEach((row) => {
ws.addRow(row)
})
wb.commit();
})() |
thanks @Alanscut, but as I understand it committing the workbook will lock the worksheet. i.e I won't be able to add any more rows.
After some investigation it looks like there isn't any performance benefit between committing all the rows together vs committing each row (using |
Any progress here? 😿 |
addRows(value, style = 'n') { |
guys we need this feature, please implement 'addRows' |
🐛 Bug Report
addRows
is defined in the type declaration but it does not exist at runtime forExcel.stream.xlsx.WorkbookWriter
.Related to #86 and #569
Lib version: 3.9.0
Looking at the source,
addRows
looks like it is not implemented for the streaming version of the WorksheetWriter.A bit of background I would like to add a large batch of rows and commit the batch instead of having to commit each row.
The text was updated successfully, but these errors were encountered: