You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Experience how it takes a long long time to parse.
The expected behaviour:
It should not be so slow. The attached file takes 1.5 minutes to parse in my Node environment. I have encountered worse examples from users of our product, and it runs in the browser, so those instances have just never finished.
Possible solution (optional, but very helpful):
I have noticed that the slow culprit is the _mergeCellsInternal function inside worksheet.js, specifically the check that cells aren't already merges. Which makes sense, because it is built with n squared loops. See my discussion here: #2568
The above code is the culprit. When I comment out this code, parsing is very fast again. Is there a way this could be more efficient? Is it even necessary? Is it necessary on first parse of the document?
The text was updated successfully, but these errors were encountered:
🐛 Bug Report
Files with too many merged cells will not load - they take too long.
Lib version: 4.4.0
Steps To Reproduce
toomanymerges.xlsx
The expected behaviour:
It should not be so slow. The attached file takes 1.5 minutes to parse in my Node environment. I have encountered worse examples from users of our product, and it runs in the browser, so those instances have just never finished.
Possible solution (optional, but very helpful):
I have noticed that the slow culprit is the
_mergeCellsInternal
function insideworksheet.js
, specifically the check that cells aren't already merges. Which makes sense, because it is built with n squared loops. See my discussion here: #2568The above code is the culprit. When I comment out this code, parsing is very fast again. Is there a way this could be more efficient? Is it even necessary? Is it necessary on first parse of the document?
The text was updated successfully, but these errors were encountered: