Skip to content

Fix Issue #1075: Unable to read/write defaultColWidth attribute in <sheetFormatPr> node #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

kigh-ota
Copy link
Contributor

@kigh-ota kigh-ota commented Jan 15, 2020

Added defaultColWidth as an optional property of SheetFormatPropertiesModel.

#1075

@kigh-ota kigh-ota force-pushed the read-and-write-defaultColWidth branch 3 times, most recently from 2323cc9 to b247766 Compare January 15, 2020 16:24
@Siemienik
Copy link
Member

@kigh-ota something went wrong during testing

@kigh-ota kigh-ota force-pushed the read-and-write-defaultColWidth branch from b247766 to f91bf3c Compare January 17, 2020 13:36
README_zh.md Outdated
@@ -274,6 +274,7 @@ worksheet.properties.defaultRowHeight = 15;
| outlineLevelCol | 0 | 工作表列大纲级别 |
| outlineLevelRow | 0 | 工作表行大纲级别 |
| defaultRowHeight | 15 | 默认行高 |
| defaultColWidth | (optional) | TBD |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| defaultColWidth | (optional) | TBD |
| defaultColWidth | (可选) | 默认列宽 |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no permission to commit it, @kigh-ota could You?

Copy link
Contributor Author

@kigh-ota kigh-ota Jan 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alanscut
Thank you for your transalation!

@Siemienik
Of course. I commited the same change.
(Maybe I should have turned on the GitHub's "Allow edits from maintainers" feature.)

@kigh-ota
Copy link
Contributor Author

@kigh-ota something went wrong during testing

@Siemienik
Rebasing to the current master resolved the problem. Could you review again?

@guyonroche guyonroche merged commit 8fb0e19 into exceljs:master Jan 21, 2020
@akof1314
Copy link

Default column width may be specified in two different ways: using defaultColWidth and baseColWidth (see documentation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants