Keep borders of merged cells after rewriting an Excel workbook #1102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix #623.
Cause of the bug
Currently, styles of cells included in a merged cell are merged and always the same after reading from file, because
Worksheet#set model()
callsCell#merge()
, which overrides the cell's style with the master (left-top) cell.exceljs/lib/doc/worksheet.js
Line 755 in cb29092
exceljs/lib/doc/cell.js
Line 172 in cb29092
However, in the original xml, each cell in a merged cell may have different styles.
For example, this file, which I created with Excel, has
sheet1.xml
like this:Thus, merging the styles drops intended cell styles, which causes #623.
Solution
Worksheet#set model()
is changed such that it parses merged cells without overriding the styles of included cells.Note
I keep the behavior of
Worksheet#mergeCells()
unchanged, since this is an API that can be used programmatically. https://github.com/exceljs/exceljs#merged-cellsAnother related issue #635 seems to correspond to this programmatic use case, but I think it can be tackled separately.