Skip to content

Add type definition for lastColumn property (fixes #1453) #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2021
Merged

Add type definition for lastColumn property (fixes #1453) #1629

merged 1 commit into from
Apr 11, 2021

Conversation

masterzeus05
Copy link
Contributor

@masterzeus05 masterzeus05 commented Mar 1, 2021 •
edited
Loading

Summary

As detected as missing in #1453, the lastColumn property has its type defined in this PR.

@masterzeus05 masterzeus05 marked this pull request as draft March 2, 2021 19:12
@masterzeus05 masterzeus05 marked this pull request as ready for review March 2, 2021 19:12
Siemienik
Siemienik approved these changes Apr 11, 2021
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:) I confirmed that the field exists in a sourcode

exceljs/lib/doc/worksheet.js

Lines 263 to 265 in ae2d2e5

get lastColumn() {
return this.getColumn(this.columnCount);
}

@Siemienik Siemienik merged commit 1499b6b into exceljs:master Apr 11, 2021
@exceljs exceljs locked as resolved and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masterzeus05 @Siemienik