Skip to content

fix: Fix xlsx.writeFile() not catching error when error occurs #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2023
Merged

fix: Fix xlsx.writeFile() not catching error when error occurs #2244

merged 4 commits into from
Apr 24, 2023

Conversation

zurmokeeper
Copy link
Contributor

@zurmokeeper zurmokeeper commented Apr 14, 2023 •
edited
Loading

Summary

When await workbook.xlsx.writeFile(filename).
was reported, but the error was not caught by try catch, after modifying the source code, it can now be caught

Test plan

try {
    const imageId2 = workbook.addImage({
        buffer: fs.readFileSync('path/to.image.png'),
        extension: 'png',
      });
    await workbook.xlsx.writeFile(filename);
} catch (error) {
    console.log(error)
}

Related to source code (for typings update)

Siemienik
Siemienik reviewed Apr 18, 2023
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, looks good for me, but test case is required before merge

@zurmokeeper
Copy link
Contributor Author

Good catch, looks good for me, but test case is required before merge

Great, I will add the test cases later

@zurmokeeper
Copy link
Contributor Author

@Siemienik Additional test cases have been added

Siemienik
Siemienik approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Siemienik Siemienik merged commit 77e549a into exceljs:master Apr 24, 2023
@j-mendez j-mendez mentioned this pull request Sep 8, 2024
Open
@Vishwas1 Vishwas1 mentioned this pull request Sep 8, 2024
Open
@j-mendez j-mendez mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

@naorpeled naorpeled naorpeled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zurmokeeper @Siemienik @naorpeled @CTyrannosaurus