-
Notifications
You must be signed in to change notification settings - Fork 1.8k
PivotTable: Support multiple values #2578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rablet
wants to merge
1
commit into
exceljs:master
Choose a base branch
from
Rablet:pivot-multiple-values
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolutely! Please see below: 1: Multiple values, no columns:
2: Attempt with multiple values & columns:
Output:
3: Showing that your scenario from the original PR still works:
Please let me know if you'd like to see anything else. |
Are you all good with this PR or do you need something else? |
is this going to get merged anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for multiple values in pivot tables.
It also allows not supplying any columns. This mimics the built-in Excel functionality where it populates the columns field with "Values".
Limitation: It is not currently possible to provide multiple values AND any columns.
With the first implementation checked in yesterday it is not possible to use multiple values. This PR removes that limitation (as long as custom columns are not used)
Test plan
I created a PivotTable with multiple values and no columns without problems.
I crated a PivotTable with one value and multiple columns without problems