-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: Support shapes and text boxes #2601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kigh-ota
wants to merge
20
commits into
exceljs:master
Choose a base branch
from
kigh-ota:support-shapes-and-text-boxes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is there any way that i can use your fork as dependency? waititng the mantainer is taking too long. |
@ijash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I created this PR based on DantSu's #2077, which I think is a great work and highly appreciate.
This PR add basic support of reading/writing shapes and textboxes.
This can broaden the use cases of the library, for example, we can load, modify and save existing Excel files including shapes and textboxes without losing them (related issues: #1147, #2086).
To help making the PR closer to merge, compared to the DantSu's PR, I did:
Note that some common functionalities, e.g. scRGB colors, font types and strikethrough styles, are still lacked in this PR.
I'm also willing to add a part to README document.
Test plan
Related to source code (for typings update)