Skip to content

Add document for zip options of streaming WorkbookWriter #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

piglovesyou
Copy link
Contributor

@ABenassi87 Added doc for you change.

Ref. #889

@alubbe
Copy link
Member

alubbe commented Aug 19, 2019

@guyonroche how do we deal with translating this to Chinese? Do we keep this PR open until someone adds a Chine translation or do we merge the PR and create a ticket for its Chinese translation?

@ABenassi87
Copy link
Contributor

@alubbe I could translate to Spanish too if you want that

@piglovesyou
Copy link
Contributor Author

Why don't we discuss how exceljs makes docs and how we translates it?

  • If every time we discuss docs and translation at the same time, documenting cost will go high
  • If documenting cost goes high, everyone stops documenting

I think documenting in English first is a good idea in order to supply a minimum and essential information fast. At the moment we can put // TODO in corresponding position in README_zh.md not to forget the later work.

@guyonroche
Copy link
Collaborator

@alubbe, @ABenassi87, @piglovesyou - translations (for Chinese so far) have come from volunteer submissions.
I (and quite a few contributors) try to keep the main English README up to date so it does tend to change with some frequency. This does mean the translations risk getting stale. I did mention this to the original Chinese contributor and he said he was happy to keep it up to date.
I expect the best option is to add a little caveat above the translations explaining this.

@ABenassi87 - by all means, if you want to add a Spanish version then it will be most welcome.

@guyonroche guyonroche merged commit f881633 into exceljs:master Oct 9, 2019
@piglovesyou piglovesyou deleted the doc-for-889 branch October 9, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants