always pass radix to parseInt. closes brianc#113

brianc · brianc · commit be5308a148e7 · 2012-03-27T09:24:45.000-04:00
diff --git a/lib/textParsers.js b/lib/textParsers.js
@@ -56,7 +56,7 @@ var parseIntegerArray = function(val) {
   if(!val) return null;
   var p = arrayParser.create(val, function(entry){
     if(entry != null)
-      entry = parseInt(entry);
+      entry = parseInt(entry, 10);
 
     return entry;
   });
@@ -83,12 +83,12 @@ var parseInterval = function(val) {
   if (!val) return {};
   var m = new RegExp(INTERVAL).exec(val);
   var i = {};
-  if (m[2]) i.years = parseInt(m[2]);
-  if (m[4]) i.months = parseInt(m[4]);
-  if (m[6]) i.days = parseInt(m[6]);
-  if (m[9]) i.hours = parseInt(m[9]);
-  if (m[10]) i.minutes = parseInt(m[10]);
-  if (m[11]) i.seconds = parseInt(m[11]);
+  if (m[2]) i.years = parseInt(m[2], 10);
+  if (m[4]) i.months = parseInt(m[4], 10);
+  if (m[6]) i.days = parseInt(m[6], 10);
+  if (m[9]) i.hours = parseInt(m[9], 10);
+  if (m[10]) i.minutes = parseInt(m[10], 10);
+  if (m[11]) i.seconds = parseInt(m[11], 10);
   if (m[8] == '-'){
       if (i.hours) i.hours *= -1;
       if (i.minutes) i.minutes *= -1;
@@ -109,11 +109,15 @@ var parseByteA = function(val) {
 
 var maxLen = Number.MAX_VALUE.toString().length
 
+var parseInteger = function(val) {
+  return parseInt(val, 10);
+}
+
 var init = function(register) {
-    register(20, parseInt);
-    register(21, parseInt);
-    register(23, parseInt);
-    register(26, parseInt);
+    register(20, parseInteger);
+    register(21, parseInteger);
+    register(23, parseInteger);
+    register(26, parseInteger);
     register(1700, function(val){
       if(val.length > maxLen) {
         console.warn('WARNING: value %s is longer than max supported numeric value in javascript. Possible data loss', val)
