Pub/Sub: add shared-config and fix lint (GoogleCloudPlatform#3441)

anguillanneuf · web-flow · commit fa7afe39a6b7 · 2020-07-30T15:59:12.000-07:00
* add shared-config and fix lint

* fix consecutive capital letters and new line for import
diff --git a/pubsub/streaming-analytics/README.md b/pubsub/streaming-analytics/README.md
@@ -86,7 +86,7 @@ The following instructions will help you prepare your development environment.
 
 ### Google Cloud Pub/Sub to Google Cloud Storage
 
-* [PubSubToGCS.java](src/main/java/com/examples/pubsub/streaming/PubSubToGCS.java)
+* [PubSubToGCS.java](src/main/java/com/examples/pubsub/streaming/PubSubToGcs.java)
 
 The following example will run a streaming pipeline. It will read messages from a Pub/Sub topic, then window them into fixed-sized intervals, and write one file per window into a GCS location.
 
diff --git a/pubsub/streaming-analytics/pom.xml b/pubsub/streaming-analytics/pom.xml
@@ -23,6 +23,12 @@
   <artifactId>pubsub-streaming</artifactId>
   <version>1.0</version>
 
+  <parent>
+    <groupId>com.google.cloud.samples</groupId>
+    <artifactId>shared-configuration</artifactId>
+    <version>1.0.17</version>
+  </parent>
+
   <properties>
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
diff --git a/pubsub/streaming-analytics/src/main/java/com/examples/pubsub/streaming/PubSubToGcs.java b/pubsub/streaming-analytics/src/main/java/com/examples/pubsub/streaming/PubSubToGcs.java
@@ -13,68 +13,69 @@
 // limitations under the License.
 
 package com.examples.pubsub.streaming;
+
 // [START pubsub_to_gcs]
+
+import java.io.IOException;
 import org.apache.beam.examples.common.WriteOneFilePerWindow;
+import org.apache.beam.sdk.Pipeline;
 import org.apache.beam.sdk.io.gcp.pubsub.PubsubIO;
 import org.apache.beam.sdk.options.Default;
 import org.apache.beam.sdk.options.Description;
 import org.apache.beam.sdk.options.PipelineOptions;
 import org.apache.beam.sdk.options.PipelineOptionsFactory;
 import org.apache.beam.sdk.options.StreamingOptions;
 import org.apache.beam.sdk.options.Validation.Required;
-import org.apache.beam.sdk.Pipeline;
 import org.apache.beam.sdk.transforms.windowing.FixedWindows;
 import org.apache.beam.sdk.transforms.windowing.Window;
 import org.joda.time.Duration;
 
-import java.io.IOException;
-
-
-public class PubSubToGCS {
+public class PubSubToGcs {
   /*
-  * Define your own configuration options. Add your own arguments to be processed
-  * by the command-line parser, and specify default values for them.
-  */
-  public interface PubSubToGCSOptions extends PipelineOptions, StreamingOptions {
+   * Define your own configuration options. Add your own arguments to be processed
+   * by the command-line parser, and specify default values for them.
+   */
+  public interface PubSubToGcsOptions extends PipelineOptions, StreamingOptions {
     @Description("The Cloud Pub/Sub topic to read from.")
     @Required
     String getInputTopic();
+
     void setInputTopic(String value);
 
     @Description("Output file's window size in number of minutes.")
     @Default.Integer(1)
     Integer getWindowSize();
+
     void setWindowSize(Integer value);
 
     @Description("Path of the output file including its filename prefix.")
     @Required
     String getOutput();
+
     void setOutput(String value);
   }
 
   public static void main(String[] args) throws IOException {
     // The maximum number of shards when writing output.
     int numShards = 1;
 
-    PubSubToGCSOptions options = PipelineOptionsFactory
-      .fromArgs(args)
-      .withValidation()
-      .as(PubSubToGCSOptions.class);
+    PubSubToGcsOptions options =
+        PipelineOptionsFactory.fromArgs(args).withValidation().as(PubSubToGcsOptions.class);
 
     options.setStreaming(true);
 
     Pipeline pipeline = Pipeline.create(options);
 
     pipeline
-      // 1) Read string messages from a Pub/Sub topic.
-      .apply("Read PubSub Messages", PubsubIO.readStrings().fromTopic(options.getInputTopic()))
-      // 2) Group the messages into fixed-sized minute intervals.
-      .apply(Window.into(FixedWindows.of(Duration.standardMinutes(options.getWindowSize()))))
-      // 3) Write one file to GCS for every window of messages.
-      .apply("Write Files to GCS", new WriteOneFilePerWindow(options.getOutput(), numShards));
+        // 1) Read string messages from a Pub/Sub topic.
+        .apply("Read PubSub Messages", PubsubIO.readStrings().fromTopic(options.getInputTopic()))
+        // 2) Group the messages into fixed-sized minute intervals.
+        .apply(Window.into(FixedWindows.of(Duration.standardMinutes(options.getWindowSize()))))
+        // 3) Write one file to GCS for every window of messages.
+        .apply("Write Files to GCS", new WriteOneFilePerWindow(options.getOutput(), numShards));
 
     // Execute the pipeline and wait until it finishes running.
     pipeline.run().waitUntilFinish();
   }
 }
-// [END pubsub_to_gcs]
+// [END pubsub_to_gcs]
