Fix EZP-24458: Refactor dynamic settings injection #1302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
178ad53 to
c7a00d6
Compare
| // This one will be transformed | ||
| $definition->addArgument( $dynamicSetting ); | ||
| $resolverArguments[] = $this->createConfigResolverSubExpression( $this->parser->parseDynamicSetting( $dynamicSetting ) ); |
|
It looks really good so far. Yay. |
c7a00d6 to
cefdcba
Compare
|
Review ping @andrerom @bdunogier @pspanja @glye @yannickroger |
|
It still looks rather good to me. |
330f2d6 to
8f231fa
Compare
|
+1, but as we need travis to run true tests please (cc @bdunogier) review the two PR's: |
8f231fa to
f8554f1
Compare
|
Rebased against master to have Travis run properly again. |
|
OK tests are now passing \o/ |
|
Looks good, +1 |
| @@ -41,7 +42,7 @@ public function process( ContainerBuilder $container ) | |||
| { | |||
| $dynamicSettingsServices = array(); | |||
| $resettableServices = array(); | |||
| $fakeServices = array(); | |||
| $updateableServices = $container->getParameter( 'ezpublish.config_resolver.updeatable_services' ); | |||
There was a problem hiding this comment.
"updeatable" speling? Not sure if existing bug or introduced here.
|
+1 apart from nitpick above. |
|
+1 |
b1063bd to
b69e85c
Compare
| @@ -21,7 +21,8 @@ class ConfigResolverParameterPassTest extends PHPUnit_Framework_TestCase | |||
| public function testProcess() | |||
| { | |||
| $container = new ContainerBuilder(); | |||
| $dynamicSettingsServices = array(); | |||
| $container->setParameter( 'ezpublish.config_resolver.updeatable_services', array() ); | |||
b69e85c to
e0568a1
Compare
> https://jira.ez.no/browse/EZP-24458 This PR removes usage of *fake* services to inject dynamic settings using factories. Instead, usage of ExpressionLanguage component is introduced.
e0568a1 to
6e9cccc
Compare
lolautruche
added a commit
that referenced
this pull request
Jun 18, 2015
…ings Fix EZP-24458: Refactor dynamic settings injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes usage of fake services to inject dynamic settings using factories.
Instead, usage of ExpressionLanguage component is introduced.
This allows to remove usage of a hack (fake services) and of a Symfony deprecated feature (synchronized services).
TODO