Fix host splitting

alexmuller · alexmuller · commit a19c780b2483 · 2015-07-24T16:09:38.000+01:00
The second parameter to `str.split()` is the maximum number of splits
to do, which means the list will have at most that many plus one
elements.

For strings which have more than 2 dots this causes an unintended
ValueError.

For example:

```
&gt;&gt;&gt; host, vdc, _ = 'host-1.vdc.env'.split('.', 3)
&gt;&gt;&gt; host, vdc, _ = 'host-1.vdc.env.computers.gov.uk'.split('.', 3)
Traceback (most recent call last):
  File "&lt;stdin&gt;", line 1, in &lt;module&gt;
ValueError: too many values to unpack
&gt;&gt;&gt; host, vdc, _ = 'host-1.vdc.env.computers.gov.uk'.split('.', 2)
```
diff --git a/fabfile.py b/fabfile.py
@@ -96,7 +96,7 @@ def fetch(self):
 
         for host in self.hosts:
             try:
-                name, vdc, _ = host.split('.', 3)
+                name, vdc, _ = host.split('.', 2)
             except ValueError:
                 warn("discarding badly formatted hostname '{0}'".format(host))
                 continue
