You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is causing the new signature to include the prior signature before replacing it. This might have been introduced with 138903f but I've had a hard time building sapling from anything other than head in the past.
A hack-fix that seems to work is adding fields["extras"].pop("gpgsig", None) prior to
I'm seeing situations where invalid GPG signatures are being attached to commits. This seems to reproduce the state:
There might be other workflows that trigger this as well (rebasing possibly). I've been working around it by grafting the busted commit.
From what I can tell, the prior
gigsig
entry is remaining in theextra
dict when generating the new commit. Inspectextra
here-ish:sapling/eden/scm/sapling/changelog.py
Line 398 in f6d1f75
This is causing the new signature to include the prior signature before replacing it. This might have been introduced with 138903f but I've had a hard time building sapling from anything other than head in the past.
A hack-fix that seems to work is adding
fields["extras"].pop("gpgsig", None)
prior tosapling/eden/scm/sapling/changelog.py
Line 401 in f6d1f75
This is seen when building from bc5cb14.
The text was updated successfully, but these errors were encountered: