let .attr(checked|selected, true) update the property

gibson042 · gibson042 · commit 06f46dad9307 · 2012-12-16T10:39:19.000-05:00
diff --git a/src/attributes.js b/src/attributes.js
@@ -489,7 +489,7 @@ boolHook = {
 
 		// Use defaultChecked and defaultSelected for oldIE
 		} else {
-			elem[ jQuery.camelCase( "default-" + name ) ] = true;
+			elem[ jQuery.camelCase( "default-" + name ) ] = elem[ name ] = true;
 		}
 
 		return name;
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
@@ -247,7 +247,7 @@ test( "attr(Hash)", function() {
 });
 
 test( "attr(String, Object)", function() {
-	expect( 67 );
+	expect( 71 );
 
 	var div = jQuery("div").attr("foo", "bar"),
 		i = 0,
@@ -281,7 +281,14 @@ test( "attr(String, Object)", function() {
 	equal( $input.attr("name"), "something", "Check element creation gets/sets the name attribute." );
 	equal( $input.attr("id"), "specified", "Check element creation gets/sets the id attribute." );
 
-	// As of fixing #11115, we make no promises about the effect of .attr on boolean properties
+	// As of fixing #11115, we only guarantee boolean property update for checked and selected
+	$input = jQuery("<input type='checkbox'/>").attr( "checked", true );
+	equal( $input.prop("checked"), true, "Setting checked updates property (verified by .prop)" );
+	equal( $input[0].checked, true, "Setting checked updates property (verified by native property)" );
+	$input = jQuery("<option/>").attr( "selected", true );
+	equal( $input.prop("selected"), true, "Setting selected updates property (verified by .prop)" );
+	equal( $input[0].selected, true, "Setting selected updates property (verified by native property)" );
+
 	$input = jQuery("#check2");
 	$input.prop( "checked", true ).prop( "checked", false ).attr( "checked", true );
 	equal( $input.attr("checked"), "checked", "Set checked (verified by .attr)" );

Original file line number	Diff line number	Diff line change
`@@ -489,7 +489,7 @@ boolHook = {`
`489`	`489`
`490`	`490`	`// Use defaultChecked and defaultSelected for oldIE`
`491`	`491`	`} else {`
`492`		`- elem[ jQuery.camelCase( "default-" + name ) ] = true;`
	`492`	`+ elem[ jQuery.camelCase( "default-" + name ) ] = elem[ name ] = true;`
`493`	`493`	`}`
`494`	`494`
`495`	`495`	`return name;`