Guard against exceptions when clearing safeChildNodes.

rwaldron · dmethvin · commit 619f0d908a42 · 2012-03-06T12:54:51.000-05:00
Supplements #11356 and fixes unit test failures in FF 3.6.
diff --git a/src/manipulation.js b/src/manipulation.js
@@ -727,10 +727,14 @@ jQuery.extend({
 					// to avoid hoarding elements. Fixes #11356
 					if ( div ) {
 						div.parentNode.removeChild( div );
-						remove = safeChildNodes[ safeChildNodes.length - 1 ];
 
-						if ( remove && remove.parentNode ) {
-							remove.parentNode.removeChild( remove );
+						// Guard against -1 index exceptions in FF3.6
+						if ( safeChildNodes.length > 0 ) {
+							remove = safeChildNodes[ safeChildNodes.length - 1 ];
+
+							if ( remove && remove.parentNode ) {
+								remove.parentNode.removeChild( remove );
+							}
 						}
 					}
 				}
diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
@@ -1740,3 +1740,15 @@ test("jQuery.fragments cache expectations", function() {
 
 	equal( fragmentCacheSize(), 12, "12 entries exist in jQuery.fragments, 2" );
 });
+
+test("Guard against exceptions when clearing safeChildNodes", function() {
+	expect( 1 );
+
+	var div;
+
+	try {
+		div = jQuery("<div/><hr/><code/><b/>");
+	} catch(e) {}
+
+	ok( div && div.jquery, "Created nodes safely, guarded against exceptions on safeChildNodes[ -1 ]" );
+});

Original file line number	Diff line number	Diff line change
`@@ -727,10 +727,14 @@ jQuery.extend({`
`727`	`727`	`// to avoid hoarding elements. Fixes #11356`
`728`	`728`	`if ( div ) {`
`729`	`729`	`div.parentNode.removeChild( div );`
`730`		`- remove = safeChildNodes[ safeChildNodes.length - 1 ];`
`731`	`730`
`732`		`- if ( remove && remove.parentNode ) {`
`733`		`- remove.parentNode.removeChild( remove );`
	`731`	`+ // Guard against -1 index exceptions in FF3.6`
	`732`	`+ if ( safeChildNodes.length > 0 ) {`
	`733`	`+ remove = safeChildNodes[ safeChildNodes.length - 1 ];`
	`734`	`+`
	`735`	`+ if ( remove && remove.parentNode ) {`
	`736`	`+ remove.parentNode.removeChild( remove );`
	`737`	`+ }`
`734`	`738`	`}`
`735`	`739`	`}`
`736`	`740`	`}`