Makes parseXML act like parseJSON when given an empty or non-string input: now returns null rather than throwing an exception. Incidently fixes #10527. Unit tests added.

jaubourg · jaubourg · commit d30859eb6bd5 · 2012-03-07T17:37:14.000+01:00
diff --git a/src/core.js b/src/core.js
@@ -557,6 +557,9 @@ jQuery.extend({
 
 	// Cross-browser xml parsing
 	parseXML: function( data ) {
+		if ( typeof data !== "string" || !data ) {
+			return null;
+		}
 		var xml, tmp;
 		try {
 			if ( window.DOMParser ) { // Standard
diff --git a/test/unit/core.js b/test/unit/core.js
@@ -1113,7 +1113,7 @@ test("jQuery.parseJSON", function(){
 	}
 });
 
-test("jQuery.parseXML", 4, function(){
+test("jQuery.parseXML", 8, function(){
 	var xml, tmp;
 	try {
 		xml = jQuery.parseXML( "<p>A <b>well-formed</b> xml string</p>" );
@@ -1131,6 +1131,18 @@ test("jQuery.parseXML", 4, function(){
 	} catch( e ) {
 		strictEqual( e.message, "Invalid XML: <p>Not a <<b>well-formed</b> xml string</p>", "invalid xml detected" );
 	}
+	try {
+		xml = jQuery.parseXML( "" );
+		strictEqual( xml, null, "empty string => null document" );
+		xml = jQuery.parseXML();
+		strictEqual( xml, null, "undefined string => null document" );
+		xml = jQuery.parseXML( null );
+		strictEqual( xml, null, "null string => null document" );
+		xml = jQuery.parseXML( true );
+		strictEqual( xml, null, "non-string => null document" );
+	} catch( e ) {
+		ok( false, "empty input throws exception" );
+	}
 });
 
 test("jQuery.sub() - Static Methods", function(){
