Spinner: Update button icons when option changes. Fixes #8926 - Spinner: Can't change icons option after init

jzaefferer · jzaefferer · commit 04d668b7171e · 2012-12-27T12:50:04.000+01:00
diff --git a/tests/unit/spinner/spinner_options.js b/tests/unit/spinner/spinner_options.js
@@ -5,10 +5,17 @@ module( "spinner: options" );
 // culture is tested after numberFormat, since it depends on numberFormat
 
 test( "icons: default ", function() {
-	expect( 2 );
-	var element = $( "#spin" ).val( 0 ).spinner().spinner( "widget" );
-	equal( element.find( ".ui-icon:first" ).attr( "class" ), "ui-icon ui-icon-triangle-1-n" );
-	equal( element.find( ".ui-icon:last" ).attr( "class" ), "ui-icon ui-icon-triangle-1-s" );
+	expect( 4 );
+	var element = $( "#spin" ).val( 0 ).spinner();
+	equal( element.spinner( "widget" ).find( ".ui-icon:first" ).attr( "class" ), "ui-icon ui-icon-triangle-1-n" );
+	equal( element.spinner( "widget" ).find( ".ui-icon:last" ).attr( "class" ), "ui-icon ui-icon-triangle-1-s" );
+
+	element.spinner( "option", "icons", {
+		up: "ui-icon-carat-1-n",
+		down: "ui-icon-carat-1-s"
+	});
+	equal( element.spinner( "widget" ).find( ".ui-icon:first" ).attr( "class" ), "ui-icon ui-icon-carat-1-n" );
+	equal( element.spinner( "widget" ).find( ".ui-icon:last" ).attr( "class" ), "ui-icon ui-icon-carat-1-s" );
 });
 
 test( "icons: custom ", function() {
diff --git a/ui/jquery.ui.spinner.js b/ui/jquery.ui.spinner.js
@@ -368,6 +368,14 @@ $.widget( "ui.spinner", {
 				value = this._parse( value );
 			}
 		}
+		if ( key === "icons" ) {
+			this.buttons.first().find( ".ui-icon" )
+				.removeClass( this.options.icons.up )
+				.addClass( value.up );
+			this.buttons.last().find( ".ui-icon" )
+				.removeClass( this.options.icons.down )
+				.addClass( value.down );
+		}
 
 		this._super( key, value );
 

Original file line number	Diff line number	Diff line change
`@@ -368,6 +368,14 @@ $.widget( "ui.spinner", {`
`368`	`368`	`value = this._parse( value );`
`369`	`369`	`}`
`370`	`370`	`}`
	`371`	`+ if ( key === "icons" ) {`
	`372`	`+ this.buttons.first().find( ".ui-icon" )`
	`373`	`+ .removeClass( this.options.icons.up )`
	`374`	`+ .addClass( value.up );`
	`375`	`+ this.buttons.last().find( ".ui-icon" )`
	`376`	`+ .removeClass( this.options.icons.down )`
	`377`	`+ .addClass( value.down );`
	`378`	`+ }`
`371`	`379`
`372`	`380`	`this._super( key, value );`
`373`	`381`