Slider: Create clone of options.values during _create(). Fixed #8892 - Multiple Sliders have Conflict with options.values.

dominicbarnes · scottgonzalez · commit 209443d71658 · 2012-12-18T11:48:10.000-05:00
diff --git a/tests/unit/slider/slider_options.js b/tests/unit/slider/slider_options.js
@@ -143,8 +143,33 @@ test("step", function() {
 //	ok(false, "missing test - untested code is broken code.");
 //});
 
-//test("values", function() {
-//	ok(false, "missing test - untested code is broken code.");
-//});
+test("values", function() {
+	expect( 2 );
+
+	// testing multiple ranges on the same page, the object reference to the values
+	// property is preserved via multiple range elements, so updating options.values
+	// of 1 slider updates options.values of all the others
+	var ranges = $([
+		document.createElement("div"),
+		document.createElement("div")
+	]).slider({
+		range:  true,
+		values: [ 25, 75 ]
+	});
+
+	notStrictEqual(
+		ranges.eq(0).data("uiSlider").options.values,
+		ranges.eq(1).data("uiSlider").options.values,
+		"multiple range sliders should not have a reference to the same options.values array"
+	);
+
+	ranges.eq(0).slider("values", 0, 10);
+
+	notEqual(
+		ranges.eq(0).slider("values", 0),
+		ranges.eq(1).slider("values", 0),
+		"the values for multiple sliders should be different"
+	);
+});
 
 })(jQuery);
diff --git a/ui/jquery.ui.slider.js b/ui/jquery.ui.slider.js
@@ -62,9 +62,10 @@ $.widget( "ui.slider", $.ui.mouse, {
 			if ( o.range === true ) {
 				if ( !o.values ) {
 					o.values = [ this._valueMin(), this._valueMin() ];
-				}
-				if ( o.values.length && o.values.length !== 2 ) {
+				} else if ( o.values.length && o.values.length !== 2 ) {
 					o.values = [ o.values[0], o.values[0] ];
+				} else if ( $.isArray( o.values ) ) {
+					o.values = o.values.slice(0);
 				}
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -62,9 +62,10 @@ $.widget( "ui.slider", $.ui.mouse, {`
`62`	`62`	`if ( o.range === true ) {`
`63`	`63`	`if ( !o.values ) {`
`64`	`64`	`o.values = [ this._valueMin(), this._valueMin() ];`
`65`		`- }`
`66`		`- if ( o.values.length && o.values.length !== 2 ) {`
	`65`	`+ } else if ( o.values.length && o.values.length !== 2 ) {`
`67`	`66`	`o.values = [ o.values[0], o.values[0] ];`
	`67`	`+ } else if ( $.isArray( o.values ) ) {`
	`68`	`+ o.values = o.values.slice(0);`
`68`	`69`	`}`
`69`	`70`	`}`
`70`	`71`