Hook cmake add_custom_command for reproducible .mo files

rocka · rocka · commit e8717b6c0666 · 2025-07-12T06:05:44.000+08:00
because msgfmt breaks .mo format for .po files with &lt;=4 strings since v0.24.1
diff --git a/lib/fcitx5/src/main/cpp/CMakeLists.txt b/lib/fcitx5/src/main/cpp/CMakeLists.txt
@@ -30,6 +30,9 @@ include("${CMAKE_CURRENT_SOURCE_DIR}/cmake/Fcitx5AndroidInstallDirs.cmake")
 # LIBDATADIR is not a standard CMake install dir, defined in fcitx5/CMakeLists.txt#L169
 set(CMAKE_INSTALL_LIBDATADIR "/usr/lib")
 
+# hook add_custom_command before configuring fcitx5
+include("${CMAKE_CURRENT_SOURCE_DIR}/cmake/HookAddCustomCommand.cmake")
+
 option(ENABLE_TEST "" OFF)
 option(ENABLE_COVERAGE "" OFF)
 option(ENABLE_ENCHANT "" OFF)
diff --git a/lib/fcitx5/src/main/cpp/cmake/FindFcitx5Utils.cmake b/lib/fcitx5/src/main/cpp/cmake/FindFcitx5Utils.cmake
@@ -19,6 +19,7 @@ find_package(Gettext REQUIRED)
 set(FCITX_INSTALL_CMAKECONFIG_DIR "${FCITX5_DEVEL_FILES}")
 
 # mimic fcitx5/src/lib/fcitx-utils/Fcitx5UtilsConfig.cmake.in
+include("${CMAKE_CURRENT_LIST_DIR}/HookAddCustomCommand.cmake") # hook before macros
 include("${FCITX_INSTALL_CMAKECONFIG_DIR}/Fcitx5Utils/Fcitx5Macros.cmake")
 include("${CMAKE_CURRENT_LIST_DIR}/Fcitx5AndroidInstallDirs.cmake")
 
diff --git a/lib/fcitx5/src/main/cpp/cmake/HookAddCustomCommand.cmake b/lib/fcitx5/src/main/cpp/cmake/HookAddCustomCommand.cmake
@@ -0,0 +1,19 @@
+find_package(Gettext)
+
+# Do as I say, not as I do
+# https://crascit.com/2018/09/14/do-not-redefine-cmake-commands/
+if (NOT COMMAND _add_custom_command)
+    function(add_custom_command)
+        cmake_parse_arguments(arg "" "" "COMMAND" ${ARGN})
+        list(GET arg_COMMAND 0 cmd_0)
+        # find calls in fcitx5_install_translation
+        if (cmd_0 STREQUAL GETTEXT_MSGFMT_EXECUTABLE AND NOT "-d" IN_LIST arg_COMMAND)
+            # ARGV is a list like: "COMMAND;/path/to/msgfmt;-o;mo_file;po_file"
+            # insert arguments after GETTEXT_MSGFMT_EXECUTABLE
+            list(FIND ARGV "${GETTEXT_MSGFMT_EXECUTABLE}" idx)
+            math(EXPR idx "${idx} + 1")
+            list(INSERT ARGV ${idx} "--no-hash" "--endianness=little")
+        endif ()
+        _add_custom_command(${ARGV})
+    endfunction()
+endif ()
