Delay check if pattern ends with slash

rstoyanchev · rstoyanchev · commit 0634555424a8 · 2013-05-10T12:47:44.000-04:00
This is a minor fix with no actual impact.

Issue: SPR-10504
diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/PatternsRequestCondition.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/PatternsRequestCondition.java
@@ -168,6 +168,7 @@ protected String getToStringInfix() {
 	 *  <li>If neither instance has patterns, use an empty String (i.e. "").
 	 * </ul>
 	 */
+	@Override
 	public PatternsRequestCondition combine(PatternsRequestCondition other) {
 		Set<String> result = new LinkedHashSet<String>();
 		if (!this.patterns.isEmpty() && !other.patterns.isEmpty()) {
@@ -209,6 +210,7 @@ else if (!other.patterns.isEmpty()) {
 	 * 		or a new condition with sorted matching patterns;
 	 * 		or {@code null} if no patterns match.
 	 */
+	@Override
 	public PatternsRequestCondition getMatchingCondition(HttpServletRequest request) {
 		if (this.patterns.isEmpty()) {
 			return this;
@@ -256,9 +258,8 @@ private String getMatchingPattern(String pattern, String lookupPath) {
 		if (this.pathMatcher.match(pattern, lookupPath)) {
 			return pattern;
 		}
-		boolean endsWithSlash = pattern.endsWith("/");
 		if (this.useTrailingSlashMatch) {
-			if (!endsWithSlash && this.pathMatcher.match(pattern + "/", lookupPath)) {
+			if (!pattern.endsWith("/") && this.pathMatcher.match(pattern + "/", lookupPath)) {
 				return pattern +"/";
 			}
 		}
@@ -277,6 +278,7 @@ private String getMatchingPattern(String pattern, String lookupPath) {
 	 * contain only patterns that match the request and are sorted with
 	 * the best matches on top.
 	 */
+	@Override
 	public int compareTo(PatternsRequestCondition other, HttpServletRequest request) {
 		String lookupPath = this.pathHelper.getLookupPathForRequest(request);
 		Comparator<String> patternComparator = this.pathMatcher.getPatternComparator(lookupPath);
