Polish @conditional Javadoc and tests

sbrannen · sbrannen · commit 96e1fbc3bbe0 · 2013-06-08T17:49:54.000+02:00
diff --git a/spring-context/src/main/java/org/springframework/context/annotation/Conditional.java b/spring-context/src/main/java/org/springframework/context/annotation/Conditional.java
@@ -22,7 +22,7 @@
 import java.lang.annotation.Target;
 
 /**
- * Indicates that a component is is only eligible for registration when all
+ * Indicates that a component is only eligible for registration when all
  * {@linkplain #value() specified conditions} match.
  *
  * <p>A <em>condition</em> is any state that can be determined programmatically
diff --git a/spring-context/src/test/java/org/springframework/context/annotation/ConfigurationClassWithConditionTests.java b/spring-context/src/test/java/org/springframework/context/annotation/ConfigurationClassWithConditionTests.java
@@ -27,6 +27,7 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
+import org.junit.After;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
@@ -36,18 +37,24 @@
 import org.springframework.stereotype.Component;
 
 /**
- * Test for {@link Conditional} beans.
- *
+ * Tests for {@link Conditional} beans.
+ * 
  * @author Phillip Webb
  */
 public class ConfigurationClassWithConditionTests {
 
+	private final AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
+
 	@Rule
 	public ExpectedException thrown = ExpectedException.none();
 
+	@After
+	public void closeContext() {
+		ctx.close();
+	}
+
 	@Test
 	public void conditionalOnMissingBeanMatch() throws Exception {
-		AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
 		ctx.register(BeanOneConfiguration.class, BeanTwoConfiguration.class);
 		ctx.refresh();
 		assertTrue(ctx.containsBean("bean1"));
@@ -57,7 +64,6 @@ public void conditionalOnMissingBeanMatch() throws Exception {
 
 	@Test
 	public void conditionalOnMissingBeanNoMatch() throws Exception {
-		AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
 		ctx.register(BeanTwoConfiguration.class);
 		ctx.refresh();
 		assertFalse(ctx.containsBean("bean1"));
@@ -67,7 +73,6 @@ public void conditionalOnMissingBeanNoMatch() throws Exception {
 
 	@Test
 	public void conditionalOnBeanMatch() throws Exception {
-		AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
 		ctx.register(BeanOneConfiguration.class, BeanThreeConfiguration.class);
 		ctx.refresh();
 		assertTrue(ctx.containsBean("bean1"));
@@ -76,7 +81,6 @@ public void conditionalOnBeanMatch() throws Exception {
 
 	@Test
 	public void conditionalOnBeanNoMatch() throws Exception {
-		AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
 		ctx.register(BeanThreeConfiguration.class);
 		ctx.refresh();
 		assertFalse(ctx.containsBean("bean1"));
@@ -85,15 +89,13 @@ public void conditionalOnBeanNoMatch() throws Exception {
 
 	@Test
 	public void metaConditional() throws Exception {
-		AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
 		ctx.register(ConfigurationWithMetaCondition.class);
 		ctx.refresh();
 		assertTrue(ctx.containsBean("bean"));
 	}
 
 	@Test
 	public void nonConfigurationClass() throws Exception {
-		AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
 		ctx.register(NonConfigurationClass.class);
 		ctx.refresh();
 		thrown.expect(NoSuchBeanDefinitionException.class);
@@ -102,7 +104,6 @@ public void nonConfigurationClass() throws Exception {
 
 	@Test
 	public void methodConditional() throws Exception {
-		AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext();
 		ctx.register(ConditionOnMethodConfiguration.class);
 		ctx.refresh();
 		thrown.expect(NoSuchBeanDefinitionException.class);

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`import java.lang.annotation.Target;`
`23`	`23`
`24`	`24`	`/**`
`25`		`- * Indicates that a component is is only eligible for registration when all`
	`25`	`+ * Indicates that a component is only eligible for registration when all`
`26`	`26`	`* {@linkplain #value() specified conditions} match.`
`27`	`27`	`*`
`28`	`28`	`* <p>A <em>condition</em> is any state that can be determined programmatically`