Turned ByteBufferConverter's visibility to package level

jhoeller · jhoeller · commit bd4c64af0493 · 2013-10-04T22:52:14.000+02:00
diff --git a/spring-core/src/main/java/org/springframework/core/convert/support/ByteBufferConverter.java b/spring-core/src/main/java/org/springframework/core/convert/support/ByteBufferConverter.java
@@ -30,8 +30,9 @@
  * any type that the {@link ConversionService} support via {@code byte[]}.
  *
  * @author Phillip Webb
+ * @since 4.0
  */
-public class ByteBufferConverter implements ConditionalGenericConverter {
+final class ByteBufferConverter implements ConditionalGenericConverter {
 
 	private static final TypeDescriptor BYTE_BUFFER_TYPE = TypeDescriptor.valueOf(ByteBuffer.class);
 
diff --git a/spring-websocket/src/test/java/org/springframework/web/socket/adapter/ConvertingEncoderDecoderSupportTests.java b/spring-websocket/src/test/java/org/springframework/web/socket/adapter/ConvertingEncoderDecoderSupportTests.java
@@ -17,7 +17,6 @@
 package org.springframework.web.socket.adapter;
 
 import java.nio.ByteBuffer;
-
 import javax.websocket.DecodeException;
 import javax.websocket.Decoder;
 import javax.websocket.EncodeException;
@@ -28,13 +27,14 @@
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.ExpectedException;
+
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.core.convert.ConversionService;
 import org.springframework.core.convert.ConverterNotFoundException;
 import org.springframework.core.convert.converter.Converter;
-import org.springframework.core.convert.support.ByteBufferConverter;
+import org.springframework.core.convert.support.DefaultConversionService;
 import org.springframework.core.convert.support.GenericConversionService;
 import org.springframework.web.context.WebApplicationContext;
 import org.springframework.web.context.support.AnnotationConfigWebApplicationContext;
@@ -188,8 +188,7 @@ public static class Config {
 
 		@Bean
 		public ConversionService webSocketConversionService() {
-			GenericConversionService conversionService = new GenericConversionService();
-			conversionService.addConverter(new ByteBufferConverter(conversionService));
+			GenericConversionService conversionService = new DefaultConversionService();
 			conversionService.addConverter(new MyTypeToStringConverter());
 			conversionService.addConverter(new MyTypeToBytesConverter());
 			conversionService.addConverter(new StringToMyTypeConverter());

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,9 @@`
`30`	`30`	`* any type that the {@link ConversionService} support via {@code byte[]}.`
`31`	`31`	`*`
`32`	`32`	`* @author Phillip Webb`
	`33`	`+ * @since 4.0`
`33`	`34`	`*/`
`34`		`-public class ByteBufferConverter implements ConditionalGenericConverter {`
	`35`	`+final class ByteBufferConverter implements ConditionalGenericConverter {`
`35`	`36`
`36`	`37`	`private static final TypeDescriptor BYTE_BUFFER_TYPE = TypeDescriptor.valueOf(ByteBuffer.class);`
`37`	`38`