update 235

fishercoder1534 · fishercoder1534 · commit 2110c6b023b7 · 2023-02-11T08:27:12.000-08:00
diff --git a/src/main/java/com/fishercoder/solutions/_235.java b/src/main/java/com/fishercoder/solutions/_235.java
@@ -9,10 +9,9 @@ public TreeNode lowestCommonAncestor(TreeNode root, TreeNode p, TreeNode q) {
             if (root == null || p == root || q == root) {
                 return root;
             }
-            if ((root.val - p.val) * (root.val - q.val) > 0) {
-                if (root.val - p.val > 0) {
-                    return lowestCommonAncestor(root.left, p, q);
-                }
+            if (root.val > p.val && root.val > q.val) {
+                return lowestCommonAncestor(root.left, p, q);
+            } else if (root.val < p.val && root.val < q.val) {
                 return lowestCommonAncestor(root.right, p, q);
             }
             return root;
diff --git a/src/test/java/com/fishercoder/_235Test.java b/src/test/java/com/fishercoder/_235Test.java
@@ -49,4 +49,18 @@ public void test2() {
 
         assertEquals(p, solution1.lowestCommonAncestor(root, p, q));
     }
+
+    @Test
+    public void test3() {
+        root = TreeUtils.constructBinaryTree(Arrays.asList(0, -1000000000, 1000000000));
+        TreeUtils.printBinaryTree(root);
+
+        p = TreeUtils.constructBinaryTree(Arrays.asList(-1000000000));
+        TreeUtils.printBinaryTree(p);
+
+        q = TreeUtils.constructBinaryTree(Arrays.asList(1000000000));
+        TreeUtils.printBinaryTree(q);
+
+        assertEquals(root, solution1.lowestCommonAncestor(root, p, q));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -9,10 +9,9 @@ public TreeNode lowestCommonAncestor(TreeNode root, TreeNode p, TreeNode q) {`
`9`	`9`	`if (root == null \|\| p == root \|\| q == root) {`
`10`	`10`	`return root;`
`11`	`11`	`}`
`12`		`- if ((root.val - p.val) * (root.val - q.val) > 0) {`
`13`		`- if (root.val - p.val > 0) {`
`14`		`- return lowestCommonAncestor(root.left, p, q);`
`15`		`- }`
	`12`	`+ if (root.val > p.val && root.val > q.val) {`
	`13`	`+ return lowestCommonAncestor(root.left, p, q);`
	`14`	`+ } else if (root.val < p.val && root.val < q.val) {`
`16`	`15`	`return lowestCommonAncestor(root.right, p, q);`
`17`	`16`	`}`
`18`	`17`	`return root;`