move schema check openapi tests into feature directories (github#35932)

rachmari · web-flow · commit 97ab8dc520a1 · 2023-03-28T16:33:58.000Z
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -46,6 +46,8 @@ jobs:
               { name: 'graphql', path: 'tests/graphql', },
               { name: 'events', path: 'src/events/tests', },
               { name: 'automated-pipelines', path: 'src/automated-pipelines/tests', },
+              { name: 'rest', path: 'src/rest/tests', },
+              { name: 'webhooks', path: 'src/webhooks/tests', },
               { name: 'linting', path: 'tests/linting', },
               { name: 'meta', path: 'tests/meta', },
               { name: 'routing', path: 'tests/routing', },
diff --git a/src/rest/tests/get-schema-files.js b/src/rest/tests/get-schema-files.js
@@ -0,0 +1,32 @@
+import { describe, expect } from '@jest/globals'
+
+import { getOpenApiSchemaFiles } from '../scripts/utils/sync.js'
+import { allVersions } from '../../../lib/all-versions.js'
+
+const supportedReleases = Object.keys(allVersions).map(
+  (version) => allVersions[version].openApiVersionName
+)
+describe('rest data files are generated correctly from dereferenced openapi files', () => {
+  test('rest schema list should include calendar date versions', async () => {
+    const schemas = [
+      'fpt-2022-08-09.json',
+      'fpt-2022-10-09.json',
+      'fpt-2022-11-09.json',
+      'ghec-2022-09-09.json',
+      ...supportedReleases,
+    ]
+
+    const expectedRestSchemas = [
+      'fpt-2022-08-09.json',
+      'fpt-2022-10-09.json',
+      'fpt-2022-11-09.json',
+      'ghec-2022-09-09.json',
+      ...supportedReleases
+        .filter((release) => release !== 'ghec' && release !== 'fpt')
+        .map((release) => `${release}.json`),
+    ]
+
+    const { restSchemas } = await getOpenApiSchemaFiles(schemas)
+    expect(restSchemas.sort()).toEqual(expectedRestSchemas.sort())
+  })
+})
diff --git a/src/webhooks/tests/get-schema-files.js b/src/webhooks/tests/get-schema-files.js
@@ -0,0 +1,24 @@
+import { describe, expect } from '@jest/globals'
+
+import { getOpenApiSchemaFiles } from '../../rest/scripts/utils/sync.js'
+import { allVersions } from '../../../lib/all-versions.js'
+
+describe('webhook data files are generated correctly from dereferenced openapi files', () => {
+  test('webhook schema list should not include calendar date versions', async () => {
+    const supportedReleases = Object.keys(allVersions).map(
+      (version) => allVersions[version].openApiVersionName
+    )
+    const schemas = [
+      'fpt-2022-08-09.json',
+      'fpt-2022-10-09.json',
+      'fpt-2022-11-09.json',
+      'ghec-2022-09-09.json',
+      ...supportedReleases,
+    ]
+
+    const { webhookSchemas } = await getOpenApiSchemaFiles(schemas)
+    expect(webhookSchemas.sort()).toEqual(
+      supportedReleases.sort().map((release) => `${release}.json`)
+    )
+  })
+})
diff --git a/tests/unit/openapi-decorator.js b/tests/unit/openapi-decorator.js
