Correctly add pure annotation

Demivan · Demivan · commit bb4764a665f4 · 2025-02-24T20:01:21.000+02:00
diff --git a/__tests__/frameworks/vite/external.spec.ts b/__tests__/frameworks/vite/external.spec.ts
@@ -178,7 +178,7 @@ describe('Vite external', () => {
     expect(code).toMatchInlineSnapshot(`
       "=== /fixtures/ftl/en/importer.js.ftl ===
 
-      export default /*#__PURE__*/ {"body":[{"id":"key","value":"Translations for js file","attributes":{}}]}
+      export default {"body":[{"id":"key","value":"Translations for js file","attributes":{}}]}
       "
     `)
   })
diff --git a/src/plugins/external-plugin.ts b/src/plugins/external-plugin.ts
@@ -132,9 +132,9 @@ export const unplugin = createUnplugin((options: ExternalPluginOptions) => {
       }
 
       if (isFtl(id)) {
-        const injectFtl = getInjectFtl(resolvedOptions)
+        const injectFtl = getInjectFtl(resolvedOptions, true)
         const result = injectFtl`
-export default /*#__PURE__*/ ${source}
+export default ${source}
 `
 
         if (result.error)
diff --git a/src/plugins/ftl/inject.ts b/src/plugins/ftl/inject.ts
@@ -8,13 +8,15 @@ function normalize(str: string) {
   return str.replace(/\r\n/g, '\n').trim()
 }
 
-export function getInjectFtl(options: { checkSyntax: boolean, parseFtl: boolean }): InjectFtlFn {
+export function getInjectFtl(options: { checkSyntax: boolean, parseFtl: boolean }, addPureAnotation = false): InjectFtlFn {
   return (template, locale, source) => {
     if (source == null) {
       source = locale
       locale = undefined
     }
 
+    const pureAnotation = addPureAnotation ? '/*#__PURE__*/ ' : ''
+
     if (source == null)
       throw new Error('Missing source')
 
@@ -39,7 +41,7 @@ export function getInjectFtl(options: { checkSyntax: boolean, parseFtl: boolean
       magic.overwrite(0, source.length, JSON.stringify(resource))
     }
     else {
-      magic.overwrite(0, source.length, `new FluentResource(${JSON.stringify(normalize(source))})`)
+      magic.overwrite(0, source.length, `${pureAnotation}new FluentResource(${JSON.stringify(normalize(source))})`)
     }
 
     if (template.length === 2) {

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ describe('Vite external', () => {`
`178`	`178`	expect(code).toMatchInlineSnapshot(`
`179`	`179`	`"=== /fixtures/ftl/en/importer.js.ftl ===`
`180`	`180`
`181`		`- export default /#__PURE__/ {"body":[{"id":"key","value":"Translations for js file","attributes":{}}]}`
	`181`	`+ export default {"body":[{"id":"key","value":"Translations for js file","attributes":{}}]}`
`182`	`182`	`"`
`183`	`183`	`)
`184`	`184`	`})`
Original file line number	Diff line number	Diff line change
`@@ -132,9 +132,9 @@ export const unplugin = createUnplugin((options: ExternalPluginOptions) => {`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`if (isFtl(id)) {`
`135`		`- const injectFtl = getInjectFtl(resolvedOptions)`
	`135`	`+ const injectFtl = getInjectFtl(resolvedOptions, true)`
`136`	`136`	const result = injectFtl`
`137`		`-export default /#__PURE__/ ${source}`
	`137`	`+export default ${source}`
`138`	`138`	`
`139`	`139`
`140`	`140`	`if (result.error)`
Original file line number	Diff line number	Diff line change
`@@ -8,13 +8,15 @@ function normalize(str: string) {`
`8`	`8`	`return str.replace(/\r\n/g, '\n').trim()`
`9`	`9`	`}`
`10`	`10`
`11`		`-export function getInjectFtl(options: { checkSyntax: boolean, parseFtl: boolean }): InjectFtlFn {`
	`11`	`+export function getInjectFtl(options: { checkSyntax: boolean, parseFtl: boolean }, addPureAnotation = false): InjectFtlFn {`
`12`	`12`	`return (template, locale, source) => {`
`13`	`13`	`if (source == null) {`
`14`	`14`	`source = locale`
`15`	`15`	`locale = undefined`
`16`	`16`	`}`
`17`	`17`
	`18`	`+ const pureAnotation = addPureAnotation ? '/#__PURE__/ ' : ''`
	`19`	`+`
`18`	`20`	`if (source == null)`
`19`	`21`	`throw new Error('Missing source')`
`20`	`22`
`@@ -39,7 +41,7 @@ export function getInjectFtl(options: { checkSyntax: boolean, parseFtl: boolean`
`39`	`41`	`magic.overwrite(0, source.length, JSON.stringify(resource))`
`40`	`42`	`}`
`41`	`43`	`else {`
`42`		- magic.overwrite(0, source.length, `new FluentResource(${JSON.stringify(normalize(source))})`)
	`44`	+ magic.overwrite(0, source.length, `${pureAnotation}new FluentResource(${JSON.stringify(normalize(source))})`)
`43`	`45`	`}`
`44`	`46`
`45`	`47`	`if (template.length === 2) {`