-
Notifications
You must be signed in to change notification settings - Fork 29k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: master
head repository: flutter/flutter
compare: flutter-3.35-candidate.0
- 20 commits
- 48 files changed
- 6 contributors
Commits on Jul 15, 2025
-
Configuration menu - View commit details
-
Copy full SHA for f85f6b6 - Browse repository at this point
Copy the full SHA f85f6b6View commit details
Commits on Jul 16, 2025
-
[3.35] Update
engine.version
(+CPs Userelease-*.version
) (#172237)Cherrypick's #172236 into the 3.35 release branch _and_ tests it live by setting `engine.version` in this PR.
Configuration menu - View commit details
-
Copy full SHA for d86b4e9 - Browse repository at this point
Copy the full SHA d86b4e9View commit details
Commits on Jul 18, 2025
-
[CP-beta]Remove emoji from ci.yaml, because we still live with CP1252…
… for some silly reason (#172263) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #172257 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples N/A ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Cannot release (Windows builder fails) ### Workaround: Is there a workaround for this issue? No ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Try publishing another release
Configuration menu - View commit details
-
Copy full SHA for 1c9c20e - Browse repository at this point
Copy the full SHA 1c9c20eView commit details
Commits on Jul 21, 2025
-
Configuration menu - View commit details
-
Copy full SHA for c0f2a1d - Browse repository at this point
Copy the full SHA c0f2a1dView commit details
Commits on Jul 22, 2025
-
[CP-beta] Add a warning on usage of
dartPluginClass: 'none'
. (#172498)This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #57497 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples N/A (Beta) ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Provides a CLI-issued warning to plugins using a workaround we wanted to remove in 2020. Once this is CP'd in 3.35, the `master` branch (post-3.35) can remove the workaround/tech debt. ### Workaround: Is there a workaround for this issue? N/A ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? N/A
Configuration menu - View commit details
-
Copy full SHA for da1b289 - Browse repository at this point
Copy the full SHA da1b289View commit details
Commits on Jul 25, 2025
-
[CP-beta]Revert #160653 Fix view removal process for AutofillContextA…
…ction.cancel (#172675) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #172250 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Fixes a bug where `TextInput.hide` call incorrect clears the text in the active text field. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) If an app calls `TextInput.hide` to hide the software keyboard, the user input in the current active text field will also be erased. It impacts the production app. The framework itself doesn't seem to call `TextInput.hide` in a way that would affect the user. ### Workaround: Is there a workaround for this issue? Yes, in theory, developers can store and restore the `TextEditingValue`, when they need to call `TextInput.hide`, to undo the clear. However I suspect the reverted PR may also [break voiceover](#145681 (comment)). ### Risk: What is the risk level of this cherry-pick? This is a revert of #160653. The reverted PR was merged in February, and the previous implementation was [introduced in 2021](flutter/engine#23776). ### Test Coverage: Are you confident that your fix is well-tested by automated tests? - [] No This change is a revert so the added test will also get reverted. ### Validation Steps: What are the steps to validate that this fix works? To verify the fix on master (it has already landed on master), run this app: ```dart import 'package:flutter/material.dart'; import 'package:flutter/services.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', debugShowCheckedModeBanner: false, theme: ThemeData( colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple), useMaterial3: true, ), home: const MyHomePage(), ); } } class MyHomePage extends StatelessWidget { const MyHomePage({super.key}); @OverRide Widget build(BuildContext context) { return Scaffold( body: Center( child: SizedBox( child: ListView( children: [ TextButton( child: Text('hide keyboard'), onPressed: () => SystemChannels.textInput.invokeListMethod("TextInput.hide"), ), TextField( controller: TextEditingController(text: '️a' * 20), maxLines: 1, ), ], ), ), ), ); } } ``` focus the text field and then click the hide keyboard button. The text "aaaaaa..." should remain after the button is clicked.
Configuration menu - View commit details
-
Copy full SHA for 789c3e3 - Browse repository at this point
Copy the full SHA 789c3e3View commit details -
[CP-beta]Fix: Ensure Text widget locale is included in semantics lang…
…uage tag (#172711) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #162324 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples This PR fixes a bug where the locale property of a Text widget was not being correctly passed to the accessibility layer, resulting in screen readers not knowing the language of the text. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) This bug critically impacted accessibility, causing screen readers to mispronounce text in foreign languages and creating a confusing, inaccessible experience for users with visual impairments. The fix ensures the locale property on the Text widget is no longer ignored, correctly passing the language information to the underlying accessibility services so the text is read intelligibly. ### Workaround: Is there a workaround for this issue? No. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Unit tests verify this change works as expected.
Configuration menu - View commit details
-
Copy full SHA for 4a371c9 - Browse repository at this point
Copy the full SHA 4a371c9View commit details
Commits on Jul 28, 2025
-
[CP-beta]Update warnGradleVersion to
8.7.0
(#172787)This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #172789 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples #172789 #172789 Using a lower version of Gradle results in a warning message to bump to a minimum of version `8.7.2`, but the warning should bump to a minimum of version `8.7.0` Reids edit: [flutter/172789](#172789) When building for Android, Change warning for minimum gradle version from 8.7.2 to 8.7.0. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) When on a lower version of Gradle, Flutter tooling would log a suggestion to bump to a minimum of `8.7.0` instead of `8.7.2` ### Workaround: Is there a workaround for this issue? Yes, the user would bump to a higher valid version of Gradle. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Use a low version of gradle and see that the Flutter tool recommends using gradle `8.7.0`
Configuration menu - View commit details
-
Copy full SHA for 31cf7a8 - Browse repository at this point
Copy the full SHA 31cf7a8View commit details
Commits on Jul 29, 2025
-
[CP-beta] Emit a warning on
--[no-]disable-dds
, preferring `--no-dd……s` (#172790) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #150279 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Emits a warning if `--[no-]disable-dds` is used, users should prefer `--[no-]dds`. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Gives a full stable release of warnings before removing a deprecated feature. ### Workaround: Is there a workaround for this issue? N/A ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? N/A
Configuration menu - View commit details
-
Copy full SHA for 3284810 - Browse repository at this point
Copy the full SHA 3284810View commit details
Commits on Jul 30, 2025
-
[CP-beta][ios]update provisioning profile for 2025-2026 cert for chro…
…mium bots (#172972) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #168427 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Updates the provisioning profile that Flutter's CI uses. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) This only impacts the release team. Without this patch, codesigning on try and prod chromium bots will fail. ### Workaround: Is there a workaround for this issue? No ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Run a test that requires codesigning, such as "Mac_x64 tool_host_cross_arch_tests"
Configuration menu - View commit details
-
Copy full SHA for def9ff9 - Browse repository at this point
Copy the full SHA def9ff9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f32d84f - Browse repository at this point
Copy the full SHA f32d84fView commit details
Commits on Jul 31, 2025
-
[CP-beta][web] Text editing test accepts both behaviors in Firefox (#…
…173053) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) ### Issue Link: #172713 ### Changelog Description: Fix web engine unit tests to work on multiple versions of Firefox. ### Impact Description: Without this fix, some unit tests fail fairly regularly on Firefox. ### Workaround: This does not affect end-users, so no workaround necessary. ### Risk: Low ### Test Coverage: Are you confident that your fix is well-tested by automated tests? Yes ### Validation Steps: Run CI.
Configuration menu - View commit details
-
Copy full SHA for 52cc75c - Browse repository at this point
Copy the full SHA 52cc75cView commit details
Commits on Aug 1, 2025
-
Update engine.version again for 3.35-0.2 (#173116)
The most recent change to fix CI on the beta branch actually touches engine unit tests, so we need to bump the engine.version again.
Configuration menu - View commit details
-
Copy full SHA for 26b84dd - Browse repository at this point
Copy the full SHA 26b84ddView commit details
Commits on Aug 6, 2025
-
[CP-beta][web] ClickDebouncer workaround for iOS Safari click behavior (
#173072) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) ### Issue Link: What is the link to the issue this cherry-pick is addressing? #172180 ### Changelog Description: Fix a bug that causes the web engine to double report taps on dropdown menu items on iOS Safari. ### Impact Description: It breaks Flutter Web apps that use dropdown menus with semantics enabled on iOS Safari. ### Workaround: Is there a workaround for this issue? No. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Follow repro steps in #172180
Configuration menu - View commit details
-
Copy full SHA for 659d955 - Browse repository at this point
Copy the full SHA 659d955View commit details -
[CP-beta]Suppress deprecated iOS windows API in integration_test (#17…
…3304) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #154365 (comment) ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Suppress an iOS deprecation warning to unblock Xcode 26 testing in CI ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Blocks Xcode 26 from being tested for the pacakges repo in CI #170437 ### Workaround: Is there a workaround for this issue? No. Packages runs the Xcode analyzer against the Flutter master and stable branches, so this deprecation suppression must go to stable ASAP. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? Tested here: https://github.com/flutter/flutter/blob/de33a3b2ab94844b091e35cae1d30b853369d308/packages/integration_test/example/integration_test/matches_golden_test.dart#L43-L45 ### Validation Steps: What are the steps to validate that this fix works? Current CI analysis will pass with or without this suppression. However, we will no longer see failures like this in packages while upgrading to Xcode 26, or increasing the minimum target version. ``` integration_test/Sources/integration_test/IntegrationTestPlugin.m:76:55: error: 'windows' is deprecated: first deprecated in iOS 15.0 - Use UIWindowScene.windows on a relevant window scene instead [-Werror,-Wdeprecated-declarations] UIWindow *window = [UIApplication.sharedApplication.windows ``` https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8738245141115055857/+/u/Run_package_tests/xcode_analyze_deprecation/stdout From flutter/packages#7542
Configuration menu - View commit details
-
Copy full SHA for 0153456 - Browse repository at this point
Copy the full SHA 0153456View commit details
Commits on Aug 7, 2025
-
Update engine version for 3.35-.03 (#173371)
Picks up two beta cherry picks: https://github.com/flutter/flutter/commits/flutter-3.35-candidate.0/ #173304 #173072
Configuration menu - View commit details
-
Copy full SHA for 9122761 - Browse repository at this point
Copy the full SHA 9122761View commit details -
[CP-beta][ios26]Do not report error for Info.plist key not found (#17…
…3438) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #172627 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Prevents a non-fatal error from causing Xcode compilation failures on macOS 26. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Building iOS flutter apps may crash with Xcode 26. ### Workaround: Is there a workaround for this issue? Add NSBonjourServices and NSLocalNetworkUsageDescription settings to your iOS app's Info.plist. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? 1. `flutter create` a new app on macOS 26 beta 2. Install Xcode 26 beta 5 3. `flutter run`
Configuration menu - View commit details
-
Copy full SHA for 40aecd7 - Browse repository at this point
Copy the full SHA 40aecd7View commit details -
[CP-beta]Prepare for iOS debugging with lldb and devicectl (#173439)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: Part 1 of #144218 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Preliminary work for a future fix to allow Xcode 26 to `flutter run` twice in a row. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Flutter developers running Xcode 26 can `flutter run` to a tethered iOS device once. However subsequent `flutter run` attempts are likely to fail. This is the first of several PRs to work around that issue. ### Workaround: Is there a workaround for this issue? Quitting and reopening Xcode. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? N/A. This PR adds the classes and functions needed for a future commit, which will turn the new feature on.
Configuration menu - View commit details
-
Copy full SHA for a10c950 - Browse repository at this point
Copy the full SHA a10c950View commit details
Commits on Aug 8, 2025
-
[CP beta] Use LLDB as the default debugging method for iOS 17+ and Xc…
…ode 26+ (#173443) (#173472) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: Part 2 of #144218 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples Implementation of a future fix to allow Xcode 26 to `flutter run` twice in a row. ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Flutter developers running Xcode 26 can `flutter run` to a tethered iOS device once. However subsequent `flutter run` attempts are likely to fail. ### Workaround: Is there a workaround for this issue? Quitting and reopening Xcode. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Create a flutter project and run `flutter run` twice in a row with a physical iOS 17+ device and Xcode 26.
Configuration menu - View commit details
-
Copy full SHA for 24a5c77 - Browse repository at this point
Copy the full SHA 24a5c77View commit details
Commits on Aug 12, 2025
-
Update Dart revision for 3.35 stable release (#173582)
Updates Dart has for 3.35 stable release to Dart 3.9 hash -- https://dart.googlesource.com/sdk/+/54588cb8088890ea08fe1a31b95efe478a4609b5. Steps I took: 1. Updated hash to desired version. 2. Run `engine/src/tools/dart/create_updated_flutter_deps.py -f DEPS` to update any Dart dependencies if needed (none updated). 3. Updated `engine/src/flutter/ci/licenses_golden/licenses_dart` with diff produced in error from https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_license/36032/overview build failure. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
Configuration menu - View commit details
-
Copy full SHA for 1ddd180 - Browse repository at this point
Copy the full SHA 1ddd180View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...flutter-3.35-candidate.0