Add compile-expression service. #16161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests? |
|
What is your plan with this PR? (No particular rush, I'm just cleaning out the review queue.) |
|
This is waiting for the dart sdk changes to land first, then this can be landed. |
b1d8b99 to
617d2fb
Compare
617d2fb to
4d8c856
Compare
|
@aam Is there a bug or PR I can follow to see when the Dart SDK changes will land? |
|
Large chunk of dart sdk changes landed here: https://dart-review.googlesource.com/c/sdk/+/54407 I'm working on the rest of it, I don't have PR for it yet. |
|
Here is tracking bug for this: dart-lang/sdk#31981 |
|
Using cirrus successful run results as a signoff, the change has been sitting in appveyor's queue for 40 minutes already, hasn't started yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vm service is used during debugging to compile user-provided expressions into kernel format.