extract engine sub-metrics; change reported metrics #55331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract sub-metrics reported by the Web engine: "preroll_frame", "apply_frame". - Add a concept of unreported metrics: displayed on the benchmark UI, but not on the dashboard. - Make "sceneBuildDuration" and "windowRenderDuration" unreported, which are too fine-grained. They are included in "drawFrameDuration" already. - Report outlier ratio instead of outlier average. The ratio is more useful of the two.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Please add a link to the engine PR in the description. That way it's easy to follow the breadcrumbs. |
Done. |
mdebbar
approved these changes
Apr 22, 2020
Comment on lines
388
to
389
| stopListeningToEngineBenchmarkValues(kProfilePrerollFrame); | ||
| stopListeningToEngineBenchmarkValues(kProfileApplyFrame); |
There was a problem hiding this comment.
Isn't it safer to put these two in the finally block?
| js_util.setProperty(html.window, '_flutter_internal_on_benchmark', _dispatchEngineBenchmarkValue); | ||
| } | ||
|
|
||
| _engineBenchmarkListeners[name] = listener; |
There was a problem hiding this comment.
Given that this will override previous listeners for name, should we throw if there's an existing listener for name?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new metrics will be added to the engine as part of flutter/engine#17852. However, this PR does not need to wait for the engine PR. If the metrics are missing, they are simply not reported.