feat(styling) Add has-error class to search when no result (for BS3)

mchapman · mchapman · commit 589595b8748d · 2015-02-20T13:17:42.000Z
diff --git a/dist/forms-angular.js b/dist/forms-angular.js
@@ -931,7 +931,7 @@ formsAngular.controller('SearchCtrl', ['$scope', '$http', '$location', 'routingS
               $scope.errorClass = '';
               $scope.setFocus(0);
             }
-            $scope.errorClass = $scope.results.length === 0 ? 'error' : '';
+            $scope.errorClass = $scope.results.length === 0 ? 'error has-error' : '';
           } else {
             clearSearchResults();
           }
diff --git a/dist/forms-angular.min.js b/dist/forms-angular.min.js
diff --git a/js/directives/search.js b/js/directives/search.js
@@ -75,7 +75,7 @@ formsAngular.controller('SearchCtrl', ['$scope', '$http', '$location', 'routingS
               $scope.errorClass = '';
               $scope.setFocus(0);
             }
-            $scope.errorClass = $scope.results.length === 0 ? 'error' : '';
+            $scope.errorClass = $scope.results.length === 0 ? 'error has-error' : '';
           } else {
             clearSearchResults();
           }
diff --git a/test/unit/searchSpec.js b/test/unit/searchSpec.js
@@ -69,7 +69,7 @@ describe('search', function () {
       var results = elm.find('span');
       expect(results.length).toBe(0);
       var div = angular.element(elm.find('div')[0]);
-      expect(div.attr('class')).toBe('control-group error');
+      expect(div.attr('class')).toBe('control-group error has-error');
       scope.searchTarget = '';
       scope.$digest();
       expect(div.attr('class')).toBe('control-group');
@@ -179,4 +179,4 @@ describe('search', function () {
   });
 
 
-});
+});

Original file line number	Diff line number	Diff line change
`@@ -931,7 +931,7 @@ formsAngular.controller('SearchCtrl', ['$scope', '$http', '$location', 'routingS`
`931`	`931`	`$scope.errorClass = '';`
`932`	`932`	`$scope.setFocus(0);`
`933`	`933`	`}`
`934`		`- $scope.errorClass = $scope.results.length === 0 ? 'error' : '';`
	`934`	`+ $scope.errorClass = $scope.results.length === 0 ? 'error has-error' : '';`
`935`	`935`	`} else {`
`936`	`936`	`clearSearchResults();`
`937`	`937`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ formsAngular.controller('SearchCtrl', ['$scope', '$http', '$location', 'routingS`
`75`	`75`	`$scope.errorClass = '';`
`76`	`76`	`$scope.setFocus(0);`
`77`	`77`	`}`
`78`		`- $scope.errorClass = $scope.results.length === 0 ? 'error' : '';`
	`78`	`+ $scope.errorClass = $scope.results.length === 0 ? 'error has-error' : '';`
`79`	`79`	`} else {`
`80`	`80`	`clearSearchResults();`
`81`	`81`	`}`