fix(styling) Makes BS3 forms have 25% of row for labels

mchapman · mchapman · commit cf2bc2d36ecb · 2015-02-26T02:00:51.000Z
Improves (I think, anyway) BS3 styling by increasing width of labels columns.

 Will affect some screen layouts in existing apps (hopefully for the better).
diff --git a/js/services/form-generator.js b/js/services/form-generator.js
@@ -658,7 +658,7 @@ formsAngular.factory('formGenerator', function (
         };
 
         $scope.skipCols = function (index) {
-            return index > 0 ? 'col-md-offset-2' : '';
+            return index > 0 ? 'col-md-offset-3' : '';
         };
 
         $scope.setFormDirty = function (event) {
diff --git a/js/services/form-markup-helper.js b/js/services/form-markup-helper.js
@@ -104,7 +104,7 @@ formsAngular.factory('formMarkupHelper', [
             // Override default label class (can be empty)
             classes += ' ' + fieldInfo.labelDefaultClass;
           } else if (cssFrameworkService.framework() === 'bs3') {
-            classes += ' col-sm-2';
+            classes += ' col-sm-3';
           }
         } else if (options.formstyle === 'inline') {
           labelHTML += ' for="' + fieldInfo.id + '"';
@@ -184,7 +184,7 @@ formsAngular.factory('formMarkupHelper', [
     exports.controlDivClasses = function (options) {
       var result = [];
       if (exports.isHorizontalStyle(options.formstyle)) {
-        result.push(cssFrameworkService.framework() === 'bs2' ? 'controls' : 'col-sm-10');
+        result.push(cssFrameworkService.framework() === 'bs2' ? 'controls' : 'col-sm-9');
       }
       return result;
     };
diff --git a/less/forms-angular-bs-common.less b/less/forms-angular-bs-common.less
@@ -23,10 +23,11 @@
 }
 
 .header-rhs {
-  width: 226px;
-  padding-right: 60px;
+  min-width: 226px;
   min-height: 40px;
-}
+  padding-right: 20px;
+  padding-bottom: 5px;
+  display: block;}
 
 .list-header .header-rhs {
   margin: 15px 0;
@@ -40,13 +41,6 @@
   z-index: 1;
 }
 
-.header-rhs {
-  width: inherited !important;
-  padding-right: 20px !important;
-  padding-bottom: 5px;
-  display: block;
-}
-
 // Modifications to ngGrid style
 
 .gridStyle {
