Change parameter name (GoogleCloudPlatform#1648)

Ace Nassri · web-flow · commit 6fd6f6bade27 · 2018-08-22T14:05:21.000-07:00
Change-Id: I2944471fab3f318a3e691031ef75419f5b3061f6
diff --git a/functions/helloworld/main.py b/functions/helloworld/main.py
@@ -58,8 +58,8 @@ def hello_http(request):
         <http://flask.pocoo.org/docs/0.12/api/#flask.Flask.make_response>.
     """
     request_json = request.get_json()
-    if request_json and 'message' in request_json:
-        name = request_json['message']
+    if request_json and 'name' in request_json:
+        name = request_json['name']
     else:
         name = 'World'
     return 'Hello, {}!'.format(name)
diff --git a/functions/helloworld/main_test.py b/functions/helloworld/main_test.py
@@ -37,7 +37,7 @@ def test_hello_http_no_args(app):
 
 
 def test_hello_http_args(app):
-    with app.test_request_context(json={'message': 'test'}):
+    with app.test_request_context(json={'name': 'test'}):
         res = main.hello_http(flask.request)
         assert 'Hello, test!' in res
 
diff --git a/functions/helloworld/sample_http_test.py b/functions/helloworld/sample_http_test.py
@@ -20,7 +20,7 @@
 
 def test_print_name():
     name = 'test'
-    req = Mock(get_json=Mock(return_value={'message': name}))
+    req = Mock(get_json=Mock(return_value={'name': name}))
 
     # Call tested function
     assert main.hello_http(req) == 'Hello, {}!'.format(name)
diff --git a/functions/helloworld/sample_http_test_system.py b/functions/helloworld/sample_http_test_system.py
@@ -34,7 +34,7 @@ def test_args():
     name = str(uuid.uuid4())
     res = requests.post(
       '{}/hello_http'.format(BASE_URL),
-      json={'message': name}
+      json={'name': name}
     )
     assert res.text == 'Hello, {}!'.format(name)
 # [END functions_http_system_test]

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ def test_args():`
`34`	`34`	`name = str(uuid.uuid4())`
`35`	`35`	`res = requests.post(`
`36`	`36`	`'{}/hello_http'.format(BASE_URL),`
`37`		`- json={'message': name}`
	`37`	`+ json={'name': name}`
`38`	`38`	`)`
`39`	`39`	`assert res.text == 'Hello, {}!'.format(name)`
`40`	`40`	`# [END functions_http_system_test]`