feat: implement pool.end()

gajus · gajus · commit 4e44e9634472 · 2022-08-02T08:43:15.000-05:00
diff --git a/README.md b/README.md
@@ -49,6 +49,7 @@ Known incompatibilities:
 
 * `connection.processID` not implemented
 * `pool._pulseQueue` not implemented
+* callback (CPS) interface not implemented (use promises instead)
 
 Please submit PR if you require additional compatibility.
 
diff --git a/src/bridge.ts b/src/bridge.ts
@@ -108,7 +108,7 @@ export const createBridge = (postgres: typeof Postgres) => {
 
           const compatibleConnection = {
             end: async () => {
-              await connection.end();
+              await this.pool.destroy(compatibleConnection);
             },
             off: connectionEvents.off.bind(connectionEvents),
             on: connectionEvents.on.bind(connectionEvents),
@@ -190,9 +190,7 @@ export const createBridge = (postgres: typeof Postgres) => {
     }
 
     public async end () {
-      for (const client of this._clients) {
-        await client.end();
-      }
+      await this.pool.clear();
     }
   };
 };
diff --git a/test/postgres-bridge/bridge.ts b/test/postgres-bridge/bridge.ts
@@ -117,6 +117,26 @@ for (const {
     await connection2.end();
   });
 
+  test(clientName + ': pool.end() destroys all connections', async (t) => {
+    const pool = new Pool({
+      user: 'postgres',
+    });
+
+    t.is(pool.totalCount, 0);
+
+    const connection1 = await pool.connect();
+    const connection2 = await pool.connect();
+
+    t.is(pool.totalCount, 2);
+
+    await connection1.release();
+    await connection2.release();
+
+    await pool.end();
+
+    t.is(pool.totalCount, 0);
+  });
+
   test(clientName + ': connection.release() releases connection back to the pool', async (t) => {
     const pool = new Pool({
       user: 'postgres',
