Skip to content

Commit 25462fd

Browse files
author
Frank Natividad
committed
Fix hanging resources and change client var name
1 parent 17d03aa commit 25462fd

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

storage/s3-sdk/src/main/java/S3Sdk.java

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,29 +36,38 @@
3636
import com.amazonaws.client.builder.AwsClientBuilder;
3737
import com.amazonaws.services.s3.AmazonS3;
3838
import com.amazonaws.services.s3.AmazonS3ClientBuilder;
39-
import com.amazonaws.services.s3.model.AmazonS3Exception;
4039
import com.amazonaws.services.s3.model.Bucket;
40+
4141
import java.util.List;
4242

4343
public class S3Sdk {
4444
public static List<Bucket> listGcsBuckets() {
4545
// Change the endpoint_url to use the Google Cloud Storage XML API endpoint.
46-
AmazonS3 s3 =
46+
AmazonS3 interopClient =
4747
AmazonS3ClientBuilder.standard()
4848
.withEndpointConfiguration(
4949
new AwsClientBuilder.EndpointConfiguration(
5050
"https://storage.googleapis.com", "auto"))
5151
.build();
5252

5353
// Call GCS to list current buckets
54-
List<Bucket> buckets = s3.listBuckets();
54+
List<Bucket> buckets = interopClient.listBuckets();
5555

5656
// Print bucket names
5757
System.out.println("Buckets:");
5858
for (Bucket bucket : buckets) {
5959
System.out.println(bucket.getName());
6060
}
61+
62+
// Explicitly clean up client resources.
63+
interopClient.shutdown();
64+
6165
return buckets;
6266
}
67+
// [END storage_s3_sdk_list_buckets]
68+
69+
public static void main(String[] args) {
70+
listGcsBuckets();
71+
}
6372
}
64-
// [END storage_s3_sdk_list_buckets]
73+

0 commit comments

Comments
 (0)