Skip to content

MaxMindBinaryProvider is not lazy and adds overhead to every request #301

Closed
@fzaninotto

Description

@fzaninotto

The GeoIP composer library (maxmind/geoip-api-php), which is required when using the MaxMindBinaryProvider, includes several files for every request (NOT lazy):

  • /geoip/geoip/src/geoip.inc
  • /geoip/geoip/src/geoipcity.inc
    • /geoip/geoip/src/geoipregiovars.inc
  • /geoip/geoip/src/timezone.php

This is a know issue, that the maxmind team chose to not fix (cf maxmind/geoip-api-php#8).

This adds between 2 and 4ms in production to every request (with APC enabled). The only way to avoid that is to remove the dependency to the GeoIP composer package, which forces the loading in its composer.json:

    "autoload": {
        "files": [
        "src/geoip.inc",
        "src/geoipcity.inc",
        "src/timezone.php"
        ]
    },

In my opinion, this justifies a more complicated installation procedure for the GeoIP provider.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions