Resolve some deprecations and remove igorw/get-in dependency #1257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@norkunas Looks interesting! Could you provide some description to your PR to explain what has been done and why ? Thanks. |
|
@jbelien Ok, will add it on monday |
|
@jbelien i've updated description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
igorw/get-independency and use PHP null-coalescing instead;assertObjectHasProperty(...)over deprecatedassertObjectHasAttribute(...);->willReturn(...)over->will($this->returnValue(...));->willReturnCallback(...)over->will($this->returnCallback(...));createPartialMockover deprecatedgetMockBuilder::setMethods(...);checkGenericClassInNonGenericObjectTypeoption;assertObjectHasPropertywas introduced only in 9.6);